Bug 16145

Summary:

[gtk] Implement media support in GTK backend

Product:

WebKit

Reporter:

Pierre-Luc Beaudoin <pierre-luc.beaudoin>

Component:

WebKitGTK

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Enhancement

CC:

alp, christian, mrowe

Priority:

Keywords:

Gtk

Version:

523.x (Safari 3)

Hardware:

OS:

Linux

Attachments:

Description	Flags
First try	none
2nd try	none
More clean-up	alp: review+

Pierre-Luc Beaudoin

Reported 2007-11-26 12:35:47 PST

The GTK+ backend currently doesn't implement media playback support for HTML 5. It should be done with GStreamer. I am working on it.

Attachments
First try (30.66 KB, patch) 2007-12-03 09:57 PST, Pierre-Luc Beaudoin	no flags	Details Formatted Diff Diff
2nd try (29.66 KB, patch) 2007-12-03 15:36 PST, Pierre-Luc Beaudoin	no flags	Details Formatted Diff Diff
More clean-up (9.25 KB, patch) 2007-12-05 13:19 PST, Pierre-Luc Beaudoin	alp: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Mark Rowe (bdash)

Comment 1 2007-11-26 18:43:05 PST

Nice!

Pierre-Luc Beaudoin

Comment 2 2007-12-03 09:57:30 PST

Created attachment 17677 [details] First try First version to be reviewed.

Alp Toker

Comment 3 2007-12-03 12:50:51 PST

I haven't looked too closely yet, but apart from the small coding issues we discussed earlier, this looks great! +gtk-port:DEFINES += ENABLE_VIDEO=1 We'll need to change that so VIDEO is only enabled when gtk-port is being compiled using the x11 backend, since the GStreamer backend is x11-specific right now. In fact it might be best to have video disabled by default for a couple of weeks until we make the feature usable and figure out how check for availability of GStreamer/gnome-vfs properly in the build system. I'd be happy to help complete this feature at some point (making the video render in the right place) if you don't have the time to do it yourself. Really nice work :-)

Pierre-Luc Beaudoin

Comment 4 2007-12-03 15:36:10 PST

Created attachment 17685 [details] 2nd try Fix licensing (now LGPL), re-apply coding conventions, disable by default on Gtk+ port.

Alp Toker

Comment 5 2007-12-04 08:35:13 PST

Comment on attachment 17685 [details] 2nd try r=me There are a few glaring style issues I'll clean up before landing, and a few more that should probably be fixed once this is in, hopefully along with patches to complete the feature. Thanks!

Alp Toker

Comment 6 2007-12-04 08:52:17 PST

Landed in r28389 with a few minor cleanups. Thanks!

Pierre-Luc Beaudoin

Comment 7 2007-12-05 13:19:13 PST

Created attachment 17725 [details] More clean-up Further clean up of the code. Removed unnecessary code and commented code. Variables now uses the code style guidelines.

Mark Rowe (bdash)

Comment 8 2007-12-05 19:47:47 PST

Comment on attachment 17685 [details] 2nd try Clearing review flag as this was landed.

Alp Toker

Comment 9 2007-12-05 21:39:42 PST

Comment on attachment 17725 [details] More clean-up r=me Looking much cleaner. ChangeLog next time please.

Note You need to log in before you can comment on or make changes to this bug.