Bug 161447

Summary: Reverse ownership relation of StyleCachedImage and CSSImageValue
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, rniwa, simon.fraser
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 161533    
Bug Blocks:    
Attachments:
Description Flags
patch
none
patch
buildbot: commit-queue-
Archive of layout-test-results from ews106 for mac-yosemite-wk2
none
Archive of layout-test-results from ews100 for mac-yosemite
none
Archive of layout-test-results from ews112 for mac-yosemite
none
patch
kling: review+, buildbot: commit-queue-
Archive of layout-test-results from ews100 for mac-yosemite
none
Archive of layout-test-results from ews105 for mac-yosemite-wk2
none
Archive of layout-test-results from ews114 for mac-yosemite
none
patch
none
patch none

Description Antti Koivisto 2016-08-31 11:55:43 PDT 
StyleCachedImage should ref the CSSValue that is backing it, not the other way round. This is how StyleGeneratedImage works already and will make the code more sane.
Comment 1 Antti Koivisto 2016-08-31 12:52:12 PDT 
Created attachment 287530 [details]
patch
Comment 2 Antti Koivisto 2016-08-31 12:58:19 PDT 
Created attachment 287532 [details]
patch
Comment 3 Build Bot 2016-08-31 13:35:02 PDT 
Comment on attachment 287532 [details]
patch

Attachment 287532 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/1982160

New failing tests:
fast/events/mouse-cursor-image-set.html
Comment 4 Build Bot 2016-08-31 13:35:05 PDT 
Created attachment 287534 [details]
Archive of layout-test-results from ews106 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 5 Build Bot 2016-08-31 13:49:13 PDT 
Comment on attachment 287532 [details]
patch

Attachment 287532 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1982240

New failing tests:
fast/events/mouse-cursor-image-set.html
Comment 6 Build Bot 2016-08-31 13:49:17 PDT 
Created attachment 287537 [details]
Archive of layout-test-results from ews100 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 7 Build Bot 2016-08-31 14:00:57 PDT 
Comment on attachment 287532 [details]
patch

Attachment 287532 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1982249

New failing tests:
fast/events/mouse-cursor-image-set.html
Comment 8 Build Bot 2016-08-31 14:00:59 PDT 
Created attachment 287540 [details]
Archive of layout-test-results from ews112 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 9 Antti Koivisto 2016-09-02 05:25:45 PDT 
Created attachment 287752 [details]
patch
Comment 10 Andreas Kling 2016-09-02 06:13:17 PDT 
Comment on attachment 287752 [details]
patch

r=me, this looks very nice.
Please fix the test failure before landing though!
Comment 11 Build Bot 2016-09-02 06:15:14 PDT 
Comment on attachment 287752 [details]
patch

Attachment 287752 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1993697

New failing tests:
fast/repaint/multiple-backgrounds-style-change.html
Comment 12 Build Bot 2016-09-02 06:15:18 PDT 
Created attachment 287753 [details]
Archive of layout-test-results from ews100 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 13 Build Bot 2016-09-02 06:19:36 PDT 
Comment on attachment 287752 [details]
patch

Attachment 287752 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/1993708

New failing tests:
fast/repaint/multiple-backgrounds-style-change.html
Comment 14 Build Bot 2016-09-02 06:19:40 PDT 
Created attachment 287754 [details]
Archive of layout-test-results from ews105 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 15 Build Bot 2016-09-02 06:23:22 PDT 
Comment on attachment 287752 [details]
patch

Attachment 287752 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1993702

New failing tests:
fast/repaint/multiple-backgrounds-style-change.html
Comment 16 Build Bot 2016-09-02 06:23:26 PDT 
Created attachment 287755 [details]
Archive of layout-test-results from ews114 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 17 Antti Koivisto 2016-09-02 06:55:36 PDT 
Created attachment 287756 [details]
patch
Comment 18 WebKit Commit Bot 2016-09-02 07:29:55 PDT 
Comment on attachment 287756 [details]
patch

Clearing flags on attachment: 287756

Committed r205344: <http://trac.webkit.org/changeset/205344>
Comment 19 WebKit Commit Bot 2016-09-02 07:30:09 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 20 WebKit Commit Bot 2016-09-02 09:25:26 PDT 
Re-opened since this is blocked by bug 161533
Comment 21 Antti Koivisto 2016-09-04 05:30:45 PDT 
Created attachment 287901 [details]
patch
Comment 22 WebKit Commit Bot 2016-09-04 06:44:38 PDT 
Comment on attachment 287901 [details]
patch

Clearing flags on attachment: 287901

Committed r205419: <http://trac.webkit.org/changeset/205419>
Comment 23 WebKit Commit Bot 2016-09-04 06:44:45 PDT 
All reviewed patches have been landed.  Closing bug.