Bug 161428

Summary: [EFL] Small clean up in MiniBrowser
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: WebKit EFLAssignee: Gyuyoung Kim <gyuyoung.kim>
Status: RESOLVED FIXED    
Severity: Normal CC: lucas.de.marchi, ossy, tonikitoo
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch ysuzuki: review+

Gyuyoung Kim
Reported 2016-08-31 00:09:30 PDT
Do below stuff. - Resize MiniBrowser size - Remove unnecessary spaces - Line breaking in too long line - Add const characters for scheme.
Attachments
Patch (15.87 KB, patch)
2016-08-31 00:10 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Patch (15.86 KB, patch)
2016-08-31 17:52 PDT, Gyuyoung Kim 		ysuzuki: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1 2016-08-31 00:10:42 PDT
Created attachment 287497 [details] Patch
Gyuyoung Kim
Comment 2 2016-08-31 17:52:32 PDT
Created attachment 287580 [details] Patch
Yusuke Suzuki
Comment 3 2016-08-31 21:42:39 PDT
Comment on attachment 287580 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=287580&action=review r=me > Tools/MiniBrowser/efl/main.c:-1060 > - eina_strbuf_append_printf(buf, "http://%s", arg); Why not using `eina_strbuf_append_printf(buf, "%s%s", HTTP_SCHEME, arg);`?
Gyuyoung Kim
Comment 4 2016-08-31 22:49:11 PDT
Committed r205279: <http://trac.webkit.org/changeset/205279>
Gyuyoung Kim
Comment 5 2016-08-31 22:50:03 PDT
(In reply to comment #3) > Comment on attachment 287580 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=287580&action=review > > r=me > > > Tools/MiniBrowser/efl/main.c:-1060 > > - eina_strbuf_append_printf(buf, "http://%s", arg); > > Why not using `eina_strbuf_append_printf(buf, "%s%s", HTTP_SCHEME, arg);`? Sure, land after fixing it.
Note You need to log in before you can comment on or make changes to this bug.