Bug 161416

Summary: "pluginReplacementEnabled" should be a Setting, not a RuntimeEnabledFeature
Product: WebKit Reporter: Ricky Mondello <rmondello>
Component: WebCore Misc.Assignee: Ricky Mondello <rmondello>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, cdumez, commit-queue, dino, eric.carlson, esprehn+autocc, gyuyoung.kim, rmondello, sam, simon.fraser, thorton
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
First attempt none

Ricky Mondello
Reported 2016-08-30 17:19:23 PDT
"pluginReplacementEnabled" should be a Setting, not a RuntimeEnabledFeature
Attachments
First attempt (11.56 KB, patch)
2016-08-30 17:29 PDT, Ricky Mondello 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ricky Mondello
Comment 1 2016-08-30 17:29:54 PDT
Created attachment 287465 [details] First attempt
WebKit Commit Bot
Comment 2 2016-08-30 18:30:26 PDT
Comment on attachment 287465 [details] First attempt Clearing flags on attachment: 287465 Committed r205214: <http://trac.webkit.org/changeset/205214>
WebKit Commit Bot
Comment 3 2016-08-30 18:30:31 PDT
All reviewed patches have been landed. Closing bug.
Alexey Proskuryakov
Comment 4 2016-08-30 23:00:07 PDT
What is the reason for this change?
Tim Horton
Comment 5 2016-08-30 23:31:18 PDT
Ricky's going to split it into two settings, and instead of adding a new runtime enabled feature (my understanding, which mostly comes from smfr, is that we don't want to add any more of those), he's moved the existing one first (a future patch will come to do the split).
Dean Jackson
Comment 6 2016-08-31 12:43:20 PDT
(In reply to comment #5) > Ricky's going to split it into two settings, and instead of adding a new > runtime enabled feature (my understanding, which mostly comes from smfr, is > that we don't want to add any more of those), he's moved the existing one > first (a future patch will come to do the split). Yep. We're going to differentiate between replacing the Flash plugin and replacing other plugins.
Dean Jackson
Comment 7 2016-08-31 12:43:45 PDT
Also <rdar://problem/28050847>
Alexey Proskuryakov
Comment 8 2016-08-31 13:30:35 PDT
> we don't want to add any more of those Thank you Tim! I think that for patches that touch runtime enabled features, it is especially important to explain them, given how scattered the knowledge is.
Alexey Proskuryakov
Comment 9 2016-08-31 13:31:22 PDT
> Yep. We're going to differentiate between replacing the Flash plugin and replacing other plugins. Also good to know!
Note You need to log in before you can comment on or make changes to this bug.