Summary: | YouTubePluginReplacementTest's URL transformation logic should have tests | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ricky Mondello <rmondello> | ||||||||
Component: | WebCore Misc. | Assignee: | Ricky Mondello <rmondello> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | commit-queue, eric.carlson, jer.noble, jonlee, rmondello, sam, simon.fraser, thorton | ||||||||
Priority: | P2 | ||||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Ricky Mondello
2016-08-30 14:36:47 PDT
Created attachment 287436 [details]
First attempt at adding some tests
Attachment 287436 [details] did not pass style-queue:
ERROR: Tools/TestWebKitAPI/Tests/WebCore/YouTubePluginReplacement.cpp:28: Found WebCore config.h after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebCore/YouTubePluginReplacement.cpp:44: Place brace on its own line for function definitions. [whitespace/braces] [4]
Total errors found: 2 in 7 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 287436 [details] First attempt at adding some tests View in context: https://bugs.webkit.org/attachment.cgi?id=287436&action=review > Tools/TestWebKitAPI/Tests/WebCore/YouTubePluginReplacement.cpp:67 > + // Even with an extra paremeter. Parameter. Created attachment 287438 [details]
Mind the style checker and fix a typo in a comment
Comment on attachment 287438 [details] Mind the style checker and fix a typo in a comment View in context: https://bugs.webkit.org/attachment.cgi?id=287438&action=review > Source/WebCore/ChangeLog:5 > + YouTubePluginReplacementTest's URL transformation logic should have tests > + https://bugs.webkit.org/show_bug.cgi?id=161406 > + Nit: please include the Radar number as well. Created attachment 287453 [details]
Incorporated Eric's review feedback.
Comment on attachment 287453 [details] Incorporated Eric's review feedback. Clearing flags on attachment: 287453 Committed r205212: <http://trac.webkit.org/changeset/205212> |