Bug 161406

Summary:

YouTubePluginReplacementTest's URL transformation logic should have tests

Product:

WebKit

Reporter:

Ricky Mondello <rmondello>

Component:

WebCore Misc.

Assignee:

Ricky Mondello <rmondello>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, eric.carlson, jer.noble, jonlee, rmondello, sam, simon.fraser, thorton

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
First attempt at adding some tests	none
Mind the style checker and fix a typo in a comment	eric.carlson: review+
Incorporated Eric's review feedback.	none

Ricky Mondello

Reported 2016-08-30 14:36:47 PDT

YouTubePluginReplacementTest's URL transformation logic should have tests

Attachments
First attempt at adding some tests (15.88 KB, patch) 2016-08-30 14:56 PDT, Ricky Mondello	no flags	Details Formatted Diff Diff
Mind the style checker and fix a typo in a comment (15.86 KB, patch) 2016-08-30 15:06 PDT, Ricky Mondello	eric.carlson: review+	Details Formatted Diff Diff
Incorporated Eric's review feedback. (15.95 KB, patch) 2016-08-30 16:44 PDT, Ricky Mondello	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Ricky Mondello

Comment 1 2016-08-30 14:56:54 PDT

Created attachment 287436 [details] First attempt at adding some tests

WebKit Commit Bot

Comment 2 2016-08-30 14:59:26 PDT

Attachment 287436 [details] did not pass style-queue: ERROR: Tools/TestWebKitAPI/Tests/WebCore/YouTubePluginReplacement.cpp:28: Found WebCore config.h after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Tools/TestWebKitAPI/Tests/WebCore/YouTubePluginReplacement.cpp:44: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 2 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.

Tim Horton

Comment 3 2016-08-30 15:02:40 PDT

Comment on attachment 287436 [details] First attempt at adding some tests View in context: https://bugs.webkit.org/attachment.cgi?id=287436&action=review > Tools/TestWebKitAPI/Tests/WebCore/YouTubePluginReplacement.cpp:67 > + // Even with an extra paremeter. Parameter.

Ricky Mondello

Comment 4 2016-08-30 15:06:48 PDT

Created attachment 287438 [details] Mind the style checker and fix a typo in a comment

Eric Carlson

Comment 5 2016-08-30 16:07:06 PDT

Comment on attachment 287438 [details] Mind the style checker and fix a typo in a comment View in context: https://bugs.webkit.org/attachment.cgi?id=287438&action=review > Source/WebCore/ChangeLog:5 > + YouTubePluginReplacementTest's URL transformation logic should have tests > + https://bugs.webkit.org/show_bug.cgi?id=161406 > + Nit: please include the Radar number as well.

Ricky Mondello

Comment 6 2016-08-30 16:44:51 PDT

Created attachment 287453 [details] Incorporated Eric's review feedback.

WebKit Commit Bot

Comment 7 2016-08-30 17:36:32 PDT

Comment on attachment 287453 [details] Incorporated Eric's review feedback. Clearing flags on attachment: 287453 Committed r205212: <http://trac.webkit.org/changeset/205212>

Note You need to log in before you can comment on or make changes to this bug.