Bug 161386 – REGRESSION (r201701): Unable to copy from CodeMirror editor version used in Jenkins install website

• Component: HTML Editing
• Status: RESOLVED FIXED

[Antti Koivisto]

This depends on very specific behavior with hidden text areas.

[Antti Koivisto]

<rdar://problem/27590077>

[Antti Koivisto]

Created attachment 287400 [details]
patch

[Antti Koivisto]

Created attachment 287402 [details]
patch

[Build Bot]

Comment on attachment 287402 [details]
patch

Attachment 287402 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1973903

New failing tests:
editing/text-iterator/hidden-textarea-selection-quirk.html

[Build Bot]

Created attachment 287409 [details]
Archive of layout-test-results from ews123 for ios-simulator-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-elcapitan-wk2  Platform: Mac OS X 10.11.5

[Antti Koivisto]

Created attachment 287416 [details]
patch

[Alexey Proskuryakov]

Comment on attachment 287416 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=287416&action=review

> LayoutTests/platform/ios-simulator/editing/text-iterator/hidden-textarea-selection-quirk-expected.txt:9
> +FAIL Selecting in barely visible textarea assert_equals: expected "test text" but got ""
> +PASS Selecting in barely visible div 
> +PASS Selecting in textarea hidden by container 
> +PASS Selecting in div hidden by container 
> +FAIL Selecting in absolute positioned textarea hidden by container assert_equals: expected "test text" but got ""
> +PASS Selecting in absolute positioned div hidden by container 
> +FAIL Selecting in absolute positioned zero content width textarea hidden by container (quirk behavior) assert_equals: expected "test text" but got ""

Could you please add a few words about the expected failures in the ChangeLog? Are these actually expected on iOS, or things that need to be fixed eventually?

[Antti Koivisto]

> Could you please add a few words about the expected failures in the
> ChangeLog? Are these actually expected on iOS, or things that need to be
> fixed eventually?

LayoutTests/ChangeLog says this:

"textarea.select() doesn't select the text content on iOS."

[WebKit Commit Bot]

Comment on attachment 287416 [details]
patch

Clearing flags on attachment: 287416

Committed r205246: <http://trac.webkit.org/changeset/205246>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Alexey Proskuryakov]

> LayoutTests/ChangeLog says this:

Oh. I was fooled by a blank line between these. I guess I'm easy to mislead :)

[Antti Koivisto]

No idea why we have this iOS behavior, it is old. I thought it's better document it rather than make a workaround in the test.

[Alexey Proskuryakov]

Makes sense.