Bug 16137 – Web Inspector window on Leopard should have a unified toolbar and window title

• Component: Web Inspector (Deprecated)
• Status: RESOLVED FIXED

[Timothy Hatcher]

The inspector window should have a unified title and toolbar. We can do this on Leopard.

[Timothy Hatcher]

Created attachment 17524 [details]
Picture of the change

[Adam Roben (:aroben)]

It would be nice to do this on Windows as well.

[Adam Roben (:aroben)]

(In reply to comment #2)
> It would be nice to do this on Windows as well.

...but we'd need transparent WebView support first.

[Timothy Hatcher]

Created attachment 17526 [details]
Patch

I will update libWebKitSystemInterfaceLeopard.a and libWebKitSystemInterfaceTiger.a when I land this.

[Timothy Hatcher]

I agree, it should be done on Windows too. Windows should use a metal window also.

[Adam Roben (:aroben)]

Comment on attachment 17526 [details]
Patch

+#if PLATFORM(MAC)
+#ifdef BUILDING_ON_TIGER
+    String platform = "mac-tiger";
+#else
+    String platform = "mac-leopard";
+#endif
+#elif PLATFORM(WIN_OS)
+    String platform = "windows";
+#elif PLATFORM(QT)
+    String platform = "qt";
+#elif PLATFORM(GTK)
+    String platform = "gtk";
+#elif PLATFORM(WX)
+    String platform = "wx";
+#else
+    String platform = "unknown";
+#endif

You should make these static const Strings.

+    JSStringRef platformString = JSStringCreateWithCharacters(platform.characters(), platform.length());

You should put this in a JSRetainPtr.

+        Add a new class to make window corners square for textured windows.

Typo: class -> function

+void WKNSWindowSquareBottomCorners(NSWindow *);

It would be nice to get a verb in there somewhere (using "square" as a verb isn't terribly clear). Maybe WKNSWindowMakeBottomCornersSquare?

r=me

[Timothy Hatcher]

Landed in r28039. http://trac.webkit.org/projects/webkit/changeset/28039