Bug 161328

Summary: fast/events/ios/viewport-shrink-to-fit-allows-double-tap.html is flaky/order dependent
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: Tools / TestsAssignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, lforschler, megan_gardner, ryanhaddad, simon.fraser, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar, LayoutTestFailure
Version: Safari 9   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=153110
Attachments:
Description Flags
Patch
none
Patch none

Alexey Proskuryakov
Reported 2016-08-29 13:44:13 PDT
fast/events/ios/viewport-shrink-to-fit-allows-double-tap.html fails most of the time for me when run like this: run-webkit-tests --ios-simulator --no-retry fast/events/ios/viewport-device-width-at-initial-scale-fast-clicks.html fast/events/ios/viewport-shrink-to-fit-allows-double-tap.html -v
Attachments
Patch (10.97 KB, patch)
2016-12-22 01:06 PST, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Patch (3.82 KB, patch)
2016-12-22 01:18 PST, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-09-26 10:00:32 PDT
<rdar://problem/28475977>
Wenson Hsieh
Comment 2 2016-12-22 01:06:34 PST
Created attachment 297649 [details] Patch
Wenson Hsieh
Comment 3 2016-12-22 01:18:54 PST
Created attachment 297650 [details] Patch
Alexey Proskuryakov
Comment 4 2016-12-22 09:09:02 PST
Comment on attachment 297650 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=297650&action=review > Tools/ChangeLog:19 > + One way to do this is to remove all animations from the WKScrollView's layer, and the layers of its children, Is this comment obsolete now?
Wenson Hsieh
Comment 5 2016-12-22 09:12:50 PST
Comment on attachment 297650 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=297650&action=review >> Tools/ChangeLog:19 >> + One way to do this is to remove all animations from the WKScrollView's layer, and the layers of its children, > > Is this comment obsolete now? This comment is still relevant. Unless all animations are removed from the WKScrollView and its children, UIKit will defer firing the end zooming callback until later (possibly in the next test).
WebKit Commit Bot
Comment 6 2016-12-22 09:38:34 PST
Comment on attachment 297650 [details] Patch Clearing flags on attachment: 297650 Committed r210101: <http://trac.webkit.org/changeset/210101>
WebKit Commit Bot
Comment 7 2016-12-22 09:38:38 PST
All reviewed patches have been landed. Closing bug.
Alexey Proskuryakov
Comment 8 2017-01-03 17:52:50 PST
Confirmed that this fixed it for me. Thanks!
Note You need to log in before you can comment on or make changes to this bug.