Bug 161322 – Stop using WebProcessProxy::fromConnection in WebPageProxy

• Component: New Bugs
• Status: RESOLVED FIXED

[Anders Carlsson]

Stop using WebProcessProxy::fromConnection in WebPageProxy

[Anders Carlsson]

Created attachment 287308 [details]
Patch

[Darin Adler]

Comment on attachment 287308 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=287308&action=review

> Source/WebKit2/ChangeLog:8
> +        The WebPageProxy alreayd knows its WebProcessProxy - no need to look it up from the connection.

Typo: already misspelled.

> Source/WebKit2/UIProcess/WebPageProxy.cpp:672
> +    ASSERT(m_process->connection() == &connection);

Is there a solid guarantee that m_process is not null in these functions?

[Anders Carlsson]

(In reply to comment #2)
> Comment on attachment 287308 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=287308&action=review
> 
> > Source/WebKit2/ChangeLog:8
> > +        The WebPageProxy alreayd knows its WebProcessProxy - no need to look it up from the connection.
> 
> Typo: already misspelled.
> 
> > Source/WebKit2/UIProcess/WebPageProxy.cpp:672
> > +    ASSERT(m_process->connection() == &connection);
> 
> Is there a solid guarantee that m_process is not null in these functions?

m_process is never null. m_process->connection() can be null during launch, but no incoming messages are dispatched at that time.

[Anders Carlsson]

Committed r205137: <http://trac.webkit.org/changeset/205137>