Bug 161306

Summary:

Move direction property into the operator dictionary

Product:

WebKit

Reporter:

Frédéric Wang (:fredw) <fred.wang>

Component:

MathML

Assignee:

Nobody <webkit-unassigned>

Status:

NEW ---

Severity:

Normal

CC:

lambda

Priority:

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Bug Depends on:

153984

Bug Blocks:

Attachments:

Description	Flags
Experimental Patch	none

Description Frédéric Wang (:fredw) 2016-08-28 23:10:00 PDT

Currently MathMLOperatorDictionary has one dictionary indexed by Operator+Form and a list of horizontal operators. We could do like in Gecko and make "horizontal" a boolean property (encoded by a new MathMLOperatorDictionary::Flag), so that it can be directly integrated into the operator dictionary and accessed via MathMLOperatorDictionary::search. We just need to ensure that all the forms have the same direction.

Comment 1 Frédéric Wang (:fredw) 2016-08-28 23:10:55 PDT

(In reply to comment #0)
> We just need to ensure that all the forms have the same direction.

... and we call MathMLOperatorDictionary::search with explicitForm = false

Comment 2 Frédéric Wang (:fredw) 2016-08-30 03:13:47 PDT

Created attachment 287383 [details]
Experimental Patch

Comment 3 Javier Fernandez 2016-09-12 05:32:56 PDT

Comment on attachment 287383 [details]
Experimental Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=287383&action=review

> Source/WebCore/mathml/MathMLOperatorElement.cpp:128
> +        break;

Why we don't return an attribute name for the case of Horizontal ?

Comment 4 Frédéric Wang (:fredw) 2016-09-12 05:35:37 PDT

Comment on attachment 287383 [details]
Experimental Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=287383&action=review

>> Source/WebCore/mathml/MathMLOperatorElement.cpp:128
>> +        break;
> 
> Why we don't return an attribute name for the case of Horizontal ?

Because horizontal is not a MathML attribute. It's just a property that we assign internally to a Unicode character.