Bug 161304 – Web Inspector: Value checks of secondsPerPixel cause errors

• Component: Web Inspector
• Status: RESOLVED FIXED

[Devin Rousso]

WebKit/WebKitBuild/Release/WebInspectorUI.framework/Resources/Views/TimelineRecordBar.js:232:23: CONSOLE ERROR
WebKit/WebKitBuild/Release/WebInspectorUI.framework/Resources/Views/TimelineDataGridNode.js:230:23: CONSOLE ERROR

Both lines are along the lines of:
console.assert(graphDataSource.secondsPerPixel);

I'm guessing that this may be due to the fact that secondsPerPixel is initially 0, which will trigger assertions.

[Radar WebKit Bug Importer]

<rdar://problem/28050070>

[Matt Baker]

These are mostly the fault of NetworkTimelineView, which wasn't clearing all its cached data on recording reset, and in addition didn't check that time stamps were actually changing before doing a layout. The latter resulted in trying to refresh graphs when endTime - startTime === 0, resulting in an invalid value for secondsPerPixel.

[Matt Baker]

Created attachment 287368 [details]
[Patch] Proposed Fix

[Blaze Burg]

Comment on attachment 287368 [details]
[Patch] Proposed Fix

This patch is missing a changelog. Ideally it would explain the sequence of events to cause this assertion and why the sequence is now different.

[Matt Baker]

Created attachment 287675 [details]
[Patch] Proposed Fix

[Blaze Burg]

Comment on attachment 287675 [details]
[Patch] Proposed Fix

r=me, very thank you for changelog ;-)

[Matt Baker]

(In reply to comment #6)
> Comment on attachment 287675 [details]
> [Patch] Proposed Fix
> 
> r=me, very thank you for changelog ;-)

It was already written, just got left behind :)

[WebKit Commit Bot]

Comment on attachment 287675 [details]
[Patch] Proposed Fix

Clearing flags on attachment: 287675

Committed r205320: <http://trac.webkit.org/changeset/205320>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.