Summary: | Web Inspector: Value checks of secondsPerPixel cause errors | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Devin Rousso <hi> | ||||||
Component: | Web Inspector | Assignee: | Matt Baker <mattbaker> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bburg, commit-queue, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Devin Rousso
2016-08-28 17:14:56 PDT
These are mostly the fault of NetworkTimelineView, which wasn't clearing all its cached data on recording reset, and in addition didn't check that time stamps were actually changing before doing a layout. The latter resulted in trying to refresh graphs when endTime - startTime === 0, resulting in an invalid value for secondsPerPixel. Created attachment 287368 [details]
[Patch] Proposed Fix
Comment on attachment 287368 [details]
[Patch] Proposed Fix
This patch is missing a changelog. Ideally it would explain the sequence of events to cause this assertion and why the sequence is now different.
Created attachment 287675 [details]
[Patch] Proposed Fix
Comment on attachment 287675 [details]
[Patch] Proposed Fix
r=me, very thank you for changelog ;-)
(In reply to comment #6) > Comment on attachment 287675 [details] > [Patch] Proposed Fix > > r=me, very thank you for changelog ;-) It was already written, just got left behind :) Comment on attachment 287675 [details] [Patch] Proposed Fix Clearing flags on attachment: 287675 Committed r205320: <http://trac.webkit.org/changeset/205320> All reviewed patches have been landed. Closing bug. |