Bug 161296 – [iOS] Build fails in JSCLLIntOffsetsExtractor - Ad Hoc code signing is not allowed with SDK 'Simulator - iOS 10.0'

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Benjamin King]

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@205094 268f45cc-cd09-0410-ab3c-d52691b4dbfc

$ sw_vers
ProductName:	Mac OS X
ProductVersion:	10.12
BuildVersion:	16A304a
$ xcode-select -p
/Applications/Xcode-beta.app/Contents/Developer
$ xcodebuild -version
Xcode 8.0
Build version 8S201h
# Xcode 8 beta 6 - Aug 15, 2016

Steps to reproduce:

1. Build WebKit: Tools/Scripts/build-webkit --ios-simulator

Expected Result: 

Should build WebKit for the iOS Simulator

Actual Result:

Build fails:

=== BUILD TARGET JSCLLIntOffsetsExtractor OF PROJECT JavaScriptCore WITH CONFIGURATION Release ===

Check dependencies
Base.xcconfig line 23: Unable to find included file "../../../../Internal/Configurations/HaveInternalSDK.xcconfig"
Ad Hoc code signing is not allowed with SDK 'Simulator - iOS 10.0'

** BUILD FAILED **


The following build commands failed:
	Check dependencies
(1 failure)

[Daniel Bates]

Created attachment 288070 [details]
Patch

Comment on attachment 288070 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=288070&action=review

> Source/JavaScriptCore/Configurations/Base.xcconfig:97
> +AD_HOC_CODE_SIGNING_ALLOWED[sdk=iphonesimulator*] = YES;

Is the sdk qualifier necessary here? If it works without it, I think we should not specify it.

[Daniel Bates]

(In reply to comment #2)
> Comment on attachment 288070 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=288070&action=review
> 
> > Source/JavaScriptCore/Configurations/Base.xcconfig:97
> > +AD_HOC_CODE_SIGNING_ALLOWED[sdk=iphonesimulator*] = YES;
> 
> Is the sdk qualifier necessary here? If it works without it, I think we
> should not specify it.

Will remove the SDK qualifier before landing as it is not necessary.

[Daniel Bates]

Committed r205528: <http://trac.webkit.org/changeset/205528>