Bug 161292

Summary: Clean up some .text attribute setters that don't throw.
Product: WebKit Reporter: Andreas Kling <kling>
Component: AccessibilityAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
darin: review+, kling: commit-queue-
Patch for landing
commit-queue: commit-queue-
Patch for landing none

Description Andreas Kling 2016-08-27 12:48:33 PDT 
These elements have a .text setter with [SetterRaisesExceptions] that will never actually throw:

HTMLAnchorElement
HTMLOptionElement
HTMLTitleElement
Comment 1 Andreas Kling 2016-08-27 12:57:56 PDT 
Created attachment 287208 [details]
Patch
Comment 2 Andreas Kling 2016-08-27 13:53:11 PDT 
Comment on attachment 287208 [details]
Patch

Looks like this needs to undo https://trac.webkit.org/changeset/203158 if/when landed.
Comment 3 Darin Adler 2016-08-27 16:47:40 PDT 
Comment on attachment 287208 [details]
Patch

Assuming you fix the gobject bindings, looks good!
Comment 4 Chris Dumez 2016-08-27 16:55:45 PDT 
Comment on attachment 287208 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=287208&action=review

> Source/WebCore/html/HTMLOptionElement.cpp:113
> +void HTMLOptionElement::setText(const String &text)

& on wrong side
Comment 5 Radar WebKit Bug Importer 2016-08-27 16:55:59 PDT 
<rdar://problem/28046467>
Comment 6 Andreas Kling 2016-08-28 07:49:19 PDT 
Created attachment 287233 [details]
Patch for landing

Attempt to fix GObject bindings.
Comment 7 WebKit Commit Bot 2016-08-28 08:48:22 PDT 
Comment on attachment 287233 [details]
Patch for landing

Rejecting attachment 287233 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 287233, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/WebKit/mac/ChangeLog contains OOPS!.

Full output: http://webkit-queues.webkit.org/results/1960257
Comment 8 Andreas Kling 2016-08-28 08:55:30 PDT 
Created attachment 287234 [details]
Patch for landing
Comment 9 WebKit Commit Bot 2016-08-28 09:56:36 PDT 
Comment on attachment 287234 [details]
Patch for landing

Clearing flags on attachment: 287234

Committed r205104: <http://trac.webkit.org/changeset/205104>
Comment 10 WebKit Commit Bot 2016-08-28 09:56:44 PDT 
All reviewed patches have been landed.  Closing bug.