Bug 161292

Summary:

Clean up some .text attribute setters that don't throw.

Product:

WebKit

Reporter:

Andreas Kling <kling>

Component:

Accessibility

Assignee:

Andreas Kling <kling>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, commit-queue, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	darin: review+, kling: commit-queue-
Patch for landing	commit-queue: commit-queue-
Patch for landing	none

Andreas Kling

Reported 2016-08-27 12:48:33 PDT

These elements have a .text setter with [SetterRaisesExceptions] that will never actually throw: HTMLAnchorElement HTMLOptionElement HTMLTitleElement

Attachments
Patch (7.10 KB, patch) 2016-08-27 12:57 PDT, Andreas Kling	darin: review+ kling: commit-queue-	Details Formatted Diff Diff
Patch for landing (12.45 KB, patch) 2016-08-28 07:49 PDT, Andreas Kling	commit-queue: commit-queue-	Details Formatted Diff Diff
Patch for landing (12.44 KB, patch) 2016-08-28 08:55 PDT, Andreas Kling	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Andreas Kling

Comment 1 2016-08-27 12:57:56 PDT

Created attachment 287208 [details] Patch

Andreas Kling

Comment 2 2016-08-27 13:53:11 PDT

Comment on attachment 287208 [details] Patch Looks like this needs to undo https://trac.webkit.org/changeset/203158 if/when landed.

Darin Adler

Comment 3 2016-08-27 16:47:40 PDT

Comment on attachment 287208 [details] Patch Assuming you fix the gobject bindings, looks good!

Chris Dumez

Comment 4 2016-08-27 16:55:45 PDT

Comment on attachment 287208 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=287208&action=review > Source/WebCore/html/HTMLOptionElement.cpp:113 > +void HTMLOptionElement::setText(const String &text) & on wrong side

Radar WebKit Bug Importer

Comment 5 2016-08-27 16:55:59 PDT

<rdar://problem/28046467>

Andreas Kling

Comment 6 2016-08-28 07:49:19 PDT

Created attachment 287233 [details] Patch for landing Attempt to fix GObject bindings.

WebKit Commit Bot

Comment 7 2016-08-28 08:48:22 PDT

Comment on attachment 287233 [details] Patch for landing Rejecting attachment 287233 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 287233, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebKit/mac/ChangeLog contains OOPS!. Full output: http://webkit-queues.webkit.org/results/1960257

Andreas Kling

Comment 8 2016-08-28 08:55:30 PDT

Created attachment 287234 [details] Patch for landing

WebKit Commit Bot

Comment 9 2016-08-28 09:56:36 PDT

Comment on attachment 287234 [details] Patch for landing Clearing flags on attachment: 287234 Committed r205104: <http://trac.webkit.org/changeset/205104>

WebKit Commit Bot

Comment 10 2016-08-28 09:56:44 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.