Bug 161281

Summary: setHostAllowsAnyHTTPSCertificate() and setClientCertificateInfo() should be guarded by "#if PLATFORM(WIN)" in ResourceHandleCurl.cpp
Product: WebKit Reporter: Yoshiaki Jitsukawa <yoshiaki.jitsukawa>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, galpeter
Priority: P2 Keywords: Curl
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
[patch] Add #if PLATFORM(WIN) guard for setHostAllowsAnyHTTPSCertificate() and setClientCertificateInfo() none

Description Yoshiaki Jitsukawa 2016-08-26 17:53:04 PDT
ResourceHandle::setHostAllowsAnyHTTPSCertificate() and ResourceHandle::setClientCertificateInfo() are declared only #if PLATFORM(WIN) && USE(CURL), but the implementation in ResourceHandleCurl.cpp is not guarded, which may cause compilation errors on the other platforms with curl support.
Comment 1 Yoshiaki Jitsukawa 2016-08-26 18:12:48 PDT
Created attachment 287184 [details]
[patch] Add #if PLATFORM(WIN) guard for setHostAllowsAnyHTTPSCertificate() and setClientCertificateInfo()
Comment 2 WebKit Commit Bot 2016-08-27 14:36:46 PDT
Comment on attachment 287184 [details]
[patch] Add #if PLATFORM(WIN) guard for setHostAllowsAnyHTTPSCertificate() and setClientCertificateInfo()

Clearing flags on attachment: 287184

Committed r205084: <http://trac.webkit.org/changeset/205084>
Comment 3 WebKit Commit Bot 2016-08-27 14:36:49 PDT
All reviewed patches have been landed.  Closing bug.