Bug 161281

Summary:

setHostAllowsAnyHTTPSCertificate() and setClientCertificateInfo() should be guarded by "#if PLATFORM(WIN)" in ResourceHandleCurl.cpp

Product:

WebKit

Reporter:

Yoshiaki Jitsukawa <yoshiaki.jitsukawa>

Component:

Platform

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, galpeter

Priority:

Keywords:

Curl

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
[patch] Add #if PLATFORM(WIN) guard for setHostAllowsAnyHTTPSCertificate() and setClientCertificateInfo()	none

Yoshiaki Jitsukawa

Reported 2016-08-26 17:53:04 PDT

ResourceHandle::setHostAllowsAnyHTTPSCertificate() and ResourceHandle::setClientCertificateInfo() are declared only #if PLATFORM(WIN) && USE(CURL), but the implementation in ResourceHandleCurl.cpp is not guarded, which may cause compilation errors on the other platforms with curl support.

Attachments
[patch] Add #if PLATFORM(WIN) guard for setHostAllowsAnyHTTPSCertificate() and setClientCertificateInfo() (1.36 KB, patch) 2016-08-26 18:12 PDT, Yoshiaki Jitsukawa	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Yoshiaki Jitsukawa

Comment 1 2016-08-26 18:12:48 PDT

Created attachment 287184 [details] [patch] Add #if PLATFORM(WIN) guard for setHostAllowsAnyHTTPSCertificate() and setClientCertificateInfo()

WebKit Commit Bot

Comment 2 2016-08-27 14:36:46 PDT

Comment on attachment 287184 [details] [patch] Add #if PLATFORM(WIN) guard for setHostAllowsAnyHTTPSCertificate() and setClientCertificateInfo() Clearing flags on attachment: 287184 Committed r205084: <http://trac.webkit.org/changeset/205084>

WebKit Commit Bot

Comment 3 2016-08-27 14:36:49 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.