Bug 161263

Summary: REGRESSION(r202568): Web Inspector: Expanding Array Prototype in Console shows no properties
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, joepeck, keith_miller, mark.lam, mattbaker, msaboff, nvasilyev, saam, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix
none
[IMAGE] Before
none
[IMAGE] After none

Joseph Pecoraro
Reported 2016-08-26 13:36:33 PDT
Summary: REGRESSION: Web Inspector: Expanding Array Prototype in Console shows no properties Steps to reproduce: 1. js> dir([]) 2. Expand Array Prototype => Says "No Properties" expected all the Array methods (sort, reduce, forEach, ...) Notes: - I think this is because [].__proto__ is an array instance with 0 length. We dropped the length requirement in <https://trac.webkit.org/r202568>
Attachments
[PATCH] Proposed Fix (7.00 KB, patch)
2016-08-26 14:46 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
[IMAGE] Before (102.71 KB, image/png)
2016-08-26 14:46 PDT, Joseph Pecoraro 		no flags
Details
[IMAGE] After (202.29 KB, image/png)
2016-08-26 14:46 PDT, Joseph Pecoraro 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-08-26 13:37:08 PDT
<rdar://problem/28035849>
Joseph Pecoraro
Comment 2 2016-08-26 14:46:24 PDT
Created attachment 287151 [details] [PATCH] Proposed Fix
Joseph Pecoraro
Comment 3 2016-08-26 14:46:42 PDT
Created attachment 287152 [details] [IMAGE] Before
Joseph Pecoraro
Comment 4 2016-08-26 14:46:54 PDT
Created attachment 287153 [details] [IMAGE] After
Matt Baker
Comment 5 2016-08-29 18:20:51 PDT
Comment on attachment 287151 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=287151&action=review r=me > LayoutTests/inspector/model/remote-object-get-properties.html:60 > + {expression: "window.arrayProto"}, Isn't the arrayProto step covered by simpleArray?
Joseph Pecoraro
Comment 6 2016-08-29 18:47:21 PDT
(In reply to comment #5) > Comment on attachment 287151 [details] > [PATCH] Proposed Fix > > View in context: > https://bugs.webkit.org/attachment.cgi?id=287151&action=review > > r=me > > > LayoutTests/inspector/model/remote-object-get-properties.html:60 > > + {expression: "window.arrayProto"}, > > Isn't the arrayProto step covered by simpleArray? Nope, but we didn't have a test for an Array so I added one.
WebKit Commit Bot
Comment 7 2016-08-29 19:09:02 PDT
Comment on attachment 287151 [details] [PATCH] Proposed Fix Clearing flags on attachment: 287151 Committed r205168: <http://trac.webkit.org/changeset/205168>
WebKit Commit Bot
Comment 8 2016-08-29 19:09:07 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.