Summary: | [Win] Enable 'warning as error' compiler setting. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Per Arne Vollan <pvollan> | ||||||
Component: | Tools / Tests | Assignee: | Per Arne Vollan <pvollan> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | achristensen, bfulgham, commit-queue, lforschler, ossy | ||||||
Priority: | P2 | ||||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Per Arne Vollan
2016-08-26 07:56:05 PDT
Created attachment 287105 [details]
Patch
Comment on attachment 287105 [details]
Patch
I'm so excited to see this getting close! Are our build bots warning-less at this point? I don't think we should land this until the build bots do not have any warnings.
(In reply to comment #2) > Comment on attachment 287105 [details] > Patch > > I'm so excited to see this getting close! Are our build bots warning-less at > this point? I don't think we should land this until the build bots do not > have any warnings. Me too :) I think I'll upload this patch once more after the other patches are landed (to check that it builds). Thanks for reviewing! Created attachment 287123 [details]
Patch
Comment on attachment 287123 [details]
Patch
The patch also builds with VS2015 Update 3.
Comment on attachment 287123 [details]
Patch
This adds /wd4206 (nonstandard extension used : translation unit is empty) and /wd4722 ('function': destructor never returns, potential memory leak). Why do we need to add 4722?
Comment on attachment 287123 [details] Patch Clearing flags on attachment: 287123 Committed r205090: <http://trac.webkit.org/changeset/205090> All reviewed patches have been landed. Closing bug. (In reply to comment #7) > Comment on attachment 287123 [details] > Patch > > Clearing flags on attachment: 287123 > > Committed r205090: <http://trac.webkit.org/changeset/205090> It broke the ApplecWindows and WinCairo build, see build.webkit.org for details. (In reply to comment #6) > Comment on attachment 287123 [details] > Patch > > This adds /wd4206 (nonstandard extension used : translation unit is empty) > and /wd4722 ('function': destructor never returns, potential memory leak). > Why do we need to add 4722? This was added because of the following code: JITWorklist::~JITWorklist() { UNREACHABLE_FOR_PLATFORM(); } |