Bug 161229

Summary: [JSC] Implement CompareStrictEq(String, Untyped) in FTL
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: New BugsAssignee: Benjamin Poulain <benjamin>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, keith_miller, mark.lam, msaboff, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Benjamin Poulain
Reported 2016-08-26 01:08:27 PDT
[JSC] Implement CompareStrictEq(String, Untyped) in FTL
Attachments
Patch (18.75 KB, patch)
2016-08-26 01:11 PDT, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Patch for landing (18.80 KB, patch)
2016-08-26 15:04 PDT, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2016-08-26 01:11:38 PDT
Created attachment 287077 [details] Patch
Geoffrey Garen
Comment 2 2016-08-26 10:50:41 PDT
Comment on attachment 287077 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=287077&action=review r=me > Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:5204 > + // Given left is string. If the value are strictly equal, rightValue has to be the same string. values
Saam Barati
Comment 3 2016-08-26 10:51:02 PDT
Comment on attachment 287077 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=287077&action=review r=me > Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:5179 > + RELEASE_ASSERT(m_node->isBinaryUseKind(UntypedUse)); Maybe make this a DFG_ASSERT?
Benjamin Poulain
Comment 4 2016-08-26 14:54:53 PDT
(In reply to comment #3) > > Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:5179 > > + RELEASE_ASSERT(m_node->isBinaryUseKind(UntypedUse)); > > Maybe make this a DFG_ASSERT? Yep, that's significantly better.
Benjamin Poulain
Comment 5 2016-08-26 15:04:36 PDT
Created attachment 287155 [details] Patch for landing
WebKit Commit Bot
Comment 6 2016-08-26 17:38:02 PDT
Comment on attachment 287155 [details] Patch for landing Clearing flags on attachment: 287155 Committed r205064: <http://trac.webkit.org/changeset/205064>
WebKit Commit Bot
Comment 7 2016-08-26 17:38:05 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.