Bug 161196

Summary: generate-js-builtins.py should generate platform independent files
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: New BugsAssignee: Csaba Osztrogonác <ossy>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, cgarcia, clopez, commit-queue, gyuyoung.kim, keith_miller, mark.lam, msaboff, ossy, saam, youennf
Priority: P2    
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Csaba Osztrogonác
Reported 2016-08-25 09:37:45 PDT
Now the order of the members are differnt on Mac and Linux platforms. I think the problem is that these members are stored in a set and the iteration order is different on different platforms. https://bugs.webkit.org/show_bug.cgi?id=159971#c18 EFL bot: https://build.webkit.org/builders/EFL%20Linux%2064-bit%20Release%20WK2/builds/29485 GTK bot: https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20%28Tests%29/builds/17870
Attachments
Patch (1.48 KB, patch)
2016-08-25 09:49 PDT, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2016-08-25 09:49:33 PDT
Created attachment 286977 [details] Patch
WebKit Commit Bot
Comment 2 2016-08-25 09:51:16 PDT
This patch modifies the JS builtins code generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-builtins-generator-tests --reset-results`)
Mark Lam
Comment 3 2016-08-25 09:52:59 PDT
Comment on attachment 286977 [details] Patch r=me
WebKit Commit Bot
Comment 4 2016-08-25 11:41:10 PDT
Comment on attachment 286977 [details] Patch Clearing flags on attachment: 286977 Committed r204979: <http://trac.webkit.org/changeset/204979>
WebKit Commit Bot
Comment 5 2016-08-25 11:41:15 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.