Bug 161196 - generate-js-builtins.py should generate platform independent files
Summary: generate-js-builtins.py should generate platform independent files
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Csaba Osztrogonác
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-08-25 09:37 PDT by Csaba Osztrogonác
Modified: 2016-08-25 11:41 PDT (History)
11 users (show)

See Also:

Attachments
Patch (1.48 KB, patch)
2016-08-25 09:49 PDT, Csaba Osztrogonác 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2016-08-25 09:37:45 PDT 
Now the order of the members are differnt on Mac and Linux platforms.

I think the problem is that these members are stored in a set
and the iteration order is different on different platforms.


https://bugs.webkit.org/show_bug.cgi?id=159971#c18

EFL bot: https://build.webkit.org/builders/EFL%20Linux%2064-bit%20Release%20WK2/builds/29485
GTK bot: https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20%28Tests%29/builds/17870
Comment 1 Csaba Osztrogonác 2016-08-25 09:49:33 PDT 
Created attachment 286977 [details]
Patch
Comment 2 WebKit Commit Bot 2016-08-25 09:51:16 PDT 
This patch modifies the JS builtins code generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-builtins-generator-tests --reset-results`)
Comment 3 Mark Lam 2016-08-25 09:52:59 PDT 
Comment on attachment 286977 [details]
Patch

r=me
Comment 4 WebKit Commit Bot 2016-08-25 11:41:10 PDT 
Comment on attachment 286977 [details]
Patch

Clearing flags on attachment: 286977

Committed r204979: <http://trac.webkit.org/changeset/204979>
Comment 5 WebKit Commit Bot 2016-08-25 11:41:15 PDT 
All reviewed patches have been landed.  Closing bug.