Bug 161180

Summary: Web Inspector: Show IndexedDB Database/ObjectStore/Index data in a details sidebar
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, beidson, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix
bburg: review+
[IMAGE] Sidebar in action none

Joseph Pecoraro
Reported 2016-08-24 20:10:28 PDT
Summary: Show IndexedDB Database/ObjectStore/Index data in a details sidebar. We already have this data, lets show it: Database name, version, securityOrigin Object Store name, keyPath, autoIncrement Index name, keyPath, unique, multiEntry
Attachments
[PATCH] Proposed Fix (13.44 KB, patch)
2016-08-24 20:13 PDT, Joseph Pecoraro 		bburg: review+
DetailsFormatted DiffDiff
[IMAGE] Sidebar in action (305.28 KB, image/png)
2016-08-24 20:13 PDT, Joseph Pecoraro 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-08-24 20:10:39 PDT
<rdar://problem/28003417>
Joseph Pecoraro
Comment 2 2016-08-24 20:13:27 PDT
Created attachment 286938 [details] [PATCH] Proposed Fix
Joseph Pecoraro
Comment 3 2016-08-24 20:13:52 PDT
Created attachment 286939 [details] [IMAGE] Sidebar in action
Brady Eidson
Comment 4 2016-08-24 21:36:30 PDT
Will review once it applies :)
Joseph Pecoraro
Comment 5 2016-08-25 00:14:00 PDT
It will never apply because localizedStrings.js :/
Blaze Burg
Comment 6 2016-08-25 15:59:33 PDT
Comment on attachment 286938 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=286938&action=review LGTM. Maybe post a screenshot for Brady? > Source/WebInspectorUI/UserInterface/Views/IndexedDatabaseDetailsSidebarPanel.js:116 > + this._objectStoreAutoIncrementRow.value = this._objectStore.autoIncrement ? WebInspector.UIString("Yes") : WebInspector.UIString("No"); Hahah, the localizers will hate this. I filed a bug to add a long description to UIString, but never found time to work on it.
Joseph Pecoraro
Comment 7 2016-08-26 14:02:02 PDT
<https://trac.webkit.org/changeset/205043>
Note You need to log in before you can comment on or make changes to this bug.