Summary: | Don't store networkLoadTiming in the disk cache | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Johan K. Jensen <jj> | ||||
Component: | Page Loading | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | achristensen, beidson, benjamin, cdumez, cgarcia, cmarcelo, commit-queue, koivisto | ||||
Priority: | P2 | ||||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Johan K. Jensen
2016-08-24 13:47:49 PDT
Created attachment 286888 [details]
Patch
Comment on attachment 286888 [details]
Patch
Looks good to me. Letting Antti look at it.
We talked about this in irc. I think that the need to do this indicates the timing data shouldn't be part of the ResourceResponse in the first place. Instead it should be passed around as a separate object (in IPC and related functions). Do we still need to do this as an intermediate step towards the desired architecture? Comment on attachment 286888 [details]
Patch
r=me because we are currently seeing disk cache crashes due to failure to bump up cache version when this stuff was added.
(In reply to comment #3) > Do we still need to do this as an intermediate step towards the desired > architecture? Yep, we don't want to redo everything right now. Comment on attachment 286888 [details]
Patch
Looks good to me. Letting Antti look at it.
|