Bug 161161

Summary: Don't store networkLoadTiming in the disk cache
Product: WebKit Reporter: Johan K. Jensen <jj>
Component: Page LoadingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, benjamin, cdumez, cgarcia, cmarcelo, commit-queue, koivisto
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch koivisto: review+, achristensen: commit-queue+

Johan K. Jensen
Reported 2016-08-24 13:47:49 PDT
The stale networkLoadTiming is not used, so save space and don't store it in the cache.
Attachments
Patch (7.14 KB, patch)
2016-08-24 13:56 PDT, Johan K. Jensen 		koivisto: review+
achristensen: commit-queue+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Johan K. Jensen
Comment 1 2016-08-24 13:56:09 PDT
Created attachment 286888 [details] Patch
Alex Christensen
Comment 2 2016-08-24 15:34:24 PDT
Comment on attachment 286888 [details] Patch Looks good to me. Letting Antti look at it.
Antti Koivisto
Comment 3 2016-08-25 04:29:25 PDT
We talked about this in irc. I think that the need to do this indicates the timing data shouldn't be part of the ResourceResponse in the first place. Instead it should be passed around as a separate object (in IPC and related functions). Do we still need to do this as an intermediate step towards the desired architecture?
Antti Koivisto
Comment 4 2016-08-25 05:42:34 PDT
Comment on attachment 286888 [details] Patch r=me because we are currently seeing disk cache crashes due to failure to bump up cache version when this stuff was added.
Alex Christensen
Comment 5 2016-08-25 11:20:57 PDT
(In reply to comment #3) > Do we still need to do this as an intermediate step towards the desired > architecture? Yep, we don't want to redo everything right now.
Alex Christensen
Comment 6 2016-08-25 11:21:14 PDT
Comment on attachment 286888 [details] Patch Looks good to me. Letting Antti look at it.
Alex Christensen
Comment 7 2016-08-25 11:26:08 PDT
http://trac.webkit.org/changeset/204977
Note You need to log in before you can comment on or make changes to this bug.