Summary: | REGRESSION: js/dom/prototype-chain-caching-with-impure-get-own-property-slot-traps-5.html has a flaky failure | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryan Haddad <ryanhaddad> | ||||
Component: | New Bugs | Assignee: | Filip Pizlo <fpizlo> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | ap, benjamin, csaavedra, fpizlo, ggaren, jfbastien, keith_miller, mark.lam, msaboff, rniwa, saam, sam, webkit-bug-importer, ysuzuki | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Ryan Haddad
2016-08-24 12:50:07 PDT
Marked test as flaky on mac in http://trac.webkit.org/projects/webkit/changeset/205196 Oh this is a real regression. We're not clearing the inline cache in time sometimes! Created attachment 312334 [details]
the patch
The test is missing an expectation file. Is this intentional? (In reply to Claudio Saavedra from comment #6) > The test is missing an expectation file. Is this intentional? I don't think so. We should add expectation file. (In reply to Yusuke Suzuki from comment #7) > (In reply to Claudio Saavedra from comment #6) > > The test is missing an expectation file. Is this intentional? > > I don't think so. We should add expectation file. I went ahead and added one in https://trac.webkit.org/changeset/218013/webkit platform/Mac/TestExpectations still has js/dom/prototype-chain-caching-with-impure-get-own-property-slot-traps-5.html listed as [ Pass Failure ], pointing to this bug. Can we remove it from the list now? (In reply to Sam Weinig from comment #9) > platform/Mac/TestExpectations still has > js/dom/prototype-chain-caching-with-impure-get-own-property-slot-traps-5. > html listed as [ Pass Failure ], pointing to this bug. Can we remove it from > the list now? I went ahead and did this: https://trac.webkit.org/changeset/218122/webkit (In reply to Saam Barati from comment #10) > (In reply to Sam Weinig from comment #9) > > platform/Mac/TestExpectations still has > > js/dom/prototype-chain-caching-with-impure-get-own-property-slot-traps-5. > > html listed as [ Pass Failure ], pointing to this bug. Can we remove it from > > the list now? > > I went ahead and did this: > https://trac.webkit.org/changeset/218122/webkit Cool cool. |