|Summary:||More cleanup for the mpadded implementation|
|Product:||WebKit||Reporter:||Frédéric Wang (:fredw) <fred.wang>|
|Component:||MathML||Assignee:||Frédéric Wang (:fredw) <fred.wang>|
|Severity:||Normal||CC:||commit-queue, dbarton, esprehn+autocc, glenn, kondapallykalyan|
|Version:||WebKit Nightly Build|
|Bug Depends on:|
Description Frédéric Wang (:fredw) 2016-08-24 06:31:47 PDT
It seems that the m_ascent member is not really needed as the ascent can be easily calculated in firstLineBaseLine() after some adjustment with how the attribute values are resolved. I was not able to find a testcase that shows how it improves dynamic update. Actually, it seems that we no longer need to override styleDidChange and updateFromElement so I'll remove them in that bug too.
Comment 2 WebKit Commit Bot 2016-08-28 01:27:55 PDT
Comment on attachment 286850 [details] Patch Clearing flags on attachment: 286850 Committed r205098: <http://trac.webkit.org/changeset/205098>
Comment 3 WebKit Commit Bot 2016-08-28 01:28:02 PDT
All reviewed patches have been landed. Closing bug.