Bug 161127

Summary:

RenderMathMLRow::firstLineBaseline does not need to be overridden in RenderMathMLMenclose

Product:

WebKit

Reporter:

Frédéric Wang (:fredw) <fred.wang>

Component:

MathML

Assignee:

Frédéric Wang (:fredw) <fred.wang>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, dbarton, esprehn+autocc, glenn, kondapallykalyan

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

155879, 161126

Attachments:

Description	Flags
Patch	darin: review+

Description Frédéric Wang (:fredw) 2016-08-23 23:41:54 PDT

RenderMathMLRow::firstLineBaseline already provides the correct calculation of ascent for non-empty menclose. Empty menclose are not used in practice so the calculation is irrelevant but aligning on mrow seems fine.

This will allow to get rid of the m_ascent member and will help to keep good vertical alignment of the 'D' in bug 161126.

Comment 1 Frédéric Wang (:fredw) 2016-08-23 23:51:27 PDT

Created attachment 286838 [details]
Patch

Comment 2 Frédéric Wang (:fredw) 2016-08-24 22:27:59 PDT

Comment on attachment 286838 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=286838&action=review

> Source/WebCore/ChangeLog:10
> +        calculated value is irrelevant. Aligning on mrow (i.e. leaving firstLineBaseline undefined)

Here it's actually "to 0" rather than "undefined".

Comment 3 Frédéric Wang (:fredw) 2016-08-28 01:43:07 PDT

Committed r205099: <http://trac.webkit.org/changeset/205099>