Bug 161124

Summary:

[iOS DRT] Make iOS DRT use the same window size as WebKitTestRunner for flexible viewport tests

Product:

WebKit

Reporter:

Simon Fraser (smfr) <simon.fraser>

Component:

New Bugs

Assignee:

Simon Fraser (smfr) <simon.fraser>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

simon.fraser

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	dbates: review+

Simon Fraser (smfr)

Reported 2016-08-23 18:55:24 PDT

[iOS DRT] Make iOS DRT use the same window size as WebKitTestRunner for flexible viewport tests

Attachments
Patch (7.02 KB, patch) 2016-08-23 18:57 PDT, Simon Fraser (smfr)	dbates: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Simon Fraser (smfr)

Comment 1 2016-08-23 18:57:53 PDT

Created attachment 286821 [details] Patch

Daniel Bates

Comment 2 2016-08-24 10:09:40 PDT

Comment on attachment 286821 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=286821&action=review > Tools/DumpRenderTree/mac/DumpRenderTree.mm:181 > -WebFrame *mainFrame = 0; > +WebFrame *mainFrame; Is this correct? Notice that this variable has external linkage. From what I recall, only variables with static storage duration are guaranteed to be zero initialized. > Tools/DumpRenderTree/mac/DumpRenderTree.mm:186 > -WebFrame *topLoadingFrame = nil; // !nil iff a load is in progress > +WebFrame *topLoadingFrame; // !nil iff a load is in progress Ditto. > Tools/DumpRenderTree/mac/DumpRenderTree.mm:189 > +CFMutableSetRef disallowedURLs; Ditto. > Tools/DumpRenderTree/mac/DumpRenderTree.mm:224 > +UIWebBrowserView *gWebBrowserView; > +UIWebScrollView *gWebScrollView; > +DumpRenderTreeWindow *gDrtWindow; Ditto.

Simon Fraser (smfr)

Comment 3 2016-08-24 13:55:33 PDT

https://trac.webkit.org/r204929

Note You need to log in before you can comment on or make changes to this bug.