Bug 161122 – Web Inspector: Test IndexedDB.requestDatabase

• Component: Web Inspector
• Status: RESOLVED FIXED

[Joseph Pecoraro]

Summary:
Test IndexedDB.requestDatabase.

Also use this opportunity to share some code across indexed db tests.

[Joseph Pecoraro]

Created attachment 286811 [details]
[PATCH] Proposed Fix

[Blaze Burg]

Comment on attachment 286811 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=286811&action=review

r=me, looks fine. But please rebase and run through EWS before landing.

> LayoutTests/inspector/indexeddb/requestDatabase.html:12
> +        name: "ClearDatabases",

It might make sense to make this a helper method and configure each test case's 'setup' parameter to run it. Then we won't even need to rebase test results when the workaround is removed.

> LayoutTests/inspector/indexeddb/requestDatabase.html:65
> +                InspectorTest.expectThat(objectStores[2].indexes.length === 2, "Object store should have 2 indexes.");

I really appreciate the good messages in these expectations.

> LayoutTests/inspector/indexeddb/requestDatabase.html:74
> +    // FIXME: <https://webkit.org/b/161121> Web Inspector: IndexedDB.requestDatabase() should not create a database if one did not exist

Oops.

[Joseph Pecoraro]

<https://trac.webkit.org/changeset/205040>