Bug 161092

Summary:

[MediaStream] Templatize MediaConstraint

Product:

WebKit

Reporter:

Eric Carlson <eric.carlson>

Component:

WebCore Misc.

Assignee:

Eric Carlson <eric.carlson>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, dino, jer.noble, thiago.lacerda, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Proposed patch.	jer.noble: review+, jer.noble: commit-queue+
Patch for landing.	none

Description Eric Carlson 2016-08-23 10:38:43 PDT

Templatize MediaConstraint

Comment 1 Eric Carlson 2016-08-23 10:42:49 PDT

Created attachment 286731 [details]
Proposed patch.

Comment 2 WebKit Commit Bot 2016-08-23 10:50:33 PDT

Attachment 286731 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/mediastream/MediaConstraints.h:96:  This { should be at the end of the previous line  [whitespace/braces] [4]
ERROR: Source/WebCore/platform/mediastream/MediaConstraints.h:105:  This { should be at the end of the previous line  [whitespace/braces] [4]
ERROR: Source/WebCore/platform/mediastream/MediaConstraints.h:114:  This { should be at the end of the previous line  [whitespace/braces] [4]
ERROR: Source/WebCore/platform/mediastream/MediaConstraints.h:123:  This { should be at the end of the previous line  [whitespace/braces] [4]
Total errors found: 4 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Eric Carlson 2016-08-23 11:13:16 PDT

Created attachment 286744 [details]
Patch for landing.

Comment 4 WebKit Commit Bot 2016-08-23 12:04:31 PDT

Comment on attachment 286744 [details]
Patch for landing.

Clearing flags on attachment: 286744

Committed r204847: <http://trac.webkit.org/changeset/204847>

Comment 5 WebKit Commit Bot 2016-08-23 12:04:37 PDT

All reviewed patches have been landed.  Closing bug.