Bug 161092 - [MediaStream] Templatize MediaConstraint
Summary: [MediaStream] Templatize MediaConstraint
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-08-23 10:38 PDT by Eric Carlson
Modified: 2016-08-23 12:04 PDT (History)
5 users (show)

See Also:


Attachments
Proposed patch. (15.60 KB, patch)
2016-08-23 10:42 PDT, Eric Carlson
jer.noble: review+
jer.noble: commit-queue+
Details | Formatted Diff | Diff
Patch for landing. (15.59 KB, patch)
2016-08-23 11:13 PDT, Eric Carlson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2016-08-23 10:38:43 PDT
Templatize MediaConstraint
Comment 1 Eric Carlson 2016-08-23 10:42:49 PDT
Created attachment 286731 [details]
Proposed patch.
Comment 2 WebKit Commit Bot 2016-08-23 10:50:33 PDT
Attachment 286731 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/mediastream/MediaConstraints.h:96:  This { should be at the end of the previous line  [whitespace/braces] [4]
ERROR: Source/WebCore/platform/mediastream/MediaConstraints.h:105:  This { should be at the end of the previous line  [whitespace/braces] [4]
ERROR: Source/WebCore/platform/mediastream/MediaConstraints.h:114:  This { should be at the end of the previous line  [whitespace/braces] [4]
ERROR: Source/WebCore/platform/mediastream/MediaConstraints.h:123:  This { should be at the end of the previous line  [whitespace/braces] [4]
Total errors found: 4 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Eric Carlson 2016-08-23 11:13:16 PDT
Created attachment 286744 [details]
Patch for landing.
Comment 4 WebKit Commit Bot 2016-08-23 12:04:31 PDT
Comment on attachment 286744 [details]
Patch for landing.

Clearing flags on attachment: 286744

Committed r204847: <http://trac.webkit.org/changeset/204847>
Comment 5 WebKit Commit Bot 2016-08-23 12:04:37 PDT
All reviewed patches have been landed.  Closing bug.