Summary: | [Win] Warning fixes. | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Per Arne Vollan <pvollan> | ||||||||
Component: | WebCore Misc. | Assignee: | Per Arne Vollan <pvollan> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | achristensen, bfulgham, commit-queue, sam | ||||||||
Priority: | P2 | ||||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Per Arne Vollan
2016-08-23 03:57:05 PDT
Created attachment 286698 [details]
Patch
Created attachment 286708 [details]
Patch
Index: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp =================================================================== --- Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp (revision 204814) +++ Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp (working copy) @@ -392,6 +392,8 @@ void GraphicsLayerCA::initialize(Type la case Type::Shape: platformLayerType = PlatformCALayer::LayerType::LayerTypeShapeLayer; break; + default: + RELEASE_ASSERT_NOT_REACHED(); } m_layer = createPlatformCALayer(platformLayerType, this); noteLayerPropertyChanged(ContentsScaleChanged); Would it be better to just return here? Created attachment 286723 [details]
Patch
Comment on attachment 286723 [details]
Patch
Nice! We're getting so close to zero warnings! :-) r=me.
Thanks for reviewing! Comment on attachment 286723 [details] Patch Clearing flags on attachment: 286723 Committed r205011: <http://trac.webkit.org/changeset/205011> All reviewed patches have been landed. Closing bug. |