Bug 161077

Summary: [Win] Warning fixes.
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: WebCore Misc.Assignee: Per Arne Vollan <pvollan>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, commit-queue, sam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Per Arne Vollan 2016-08-23 03:57:05 PDT
There are still a few warnings left in WebCore.
Comment 1 Per Arne Vollan 2016-08-23 04:17:12 PDT
Created attachment 286698 [details]
Patch
Comment 2 Per Arne Vollan 2016-08-23 06:36:36 PDT
Created attachment 286708 [details]
Patch
Comment 3 Per Arne Vollan 2016-08-23 06:41:20 PDT
Index: Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp
===================================================================
--- Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp	(revision 204814)
+++ Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp	(working copy)
@@ -392,6 +392,8 @@ void GraphicsLayerCA::initialize(Type la
     case Type::Shape:
         platformLayerType = PlatformCALayer::LayerType::LayerTypeShapeLayer;
         break;
+    default:
+        RELEASE_ASSERT_NOT_REACHED();
     }
     m_layer = createPlatformCALayer(platformLayerType, this);
     noteLayerPropertyChanged(ContentsScaleChanged);

Would it be better to just return here?
Comment 4 Per Arne Vollan 2016-08-23 10:00:05 PDT
Created attachment 286723 [details]
Patch
Comment 5 Brent Fulgham 2016-08-25 12:34:20 PDT
Comment on attachment 286723 [details]
Patch

Nice! We're getting so close to zero warnings! :-) r=me.
Comment 6 Per Arne Vollan 2016-08-26 06:08:59 PDT
Thanks for reviewing!
Comment 7 WebKit Commit Bot 2016-08-26 06:31:18 PDT
Comment on attachment 286723 [details]
Patch

Clearing flags on attachment: 286723

Committed r205011: <http://trac.webkit.org/changeset/205011>
Comment 8 WebKit Commit Bot 2016-08-26 06:31:22 PDT
All reviewed patches have been landed.  Closing bug.