Summary: | DOMTokenList’s value and stringifier should not return parsed tokens | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> | ||||
Component: | DOM | Assignee: | Ryosuke Niwa <rniwa> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | benjamin, cdumez, commit-queue, darin, esprehn+autocc, gyuyoung.kim | ||||
Priority: | P2 | ||||||
Version: | Other | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Ryosuke Niwa
2016-08-23 00:32:09 PDT
Created attachment 286688 [details]
Patch
Comment on attachment 286688 [details]
Patch
The spec has changed recently after we implemented it. I am working on getting the spec back the way it was. Our current behavior is nicer, this patch makes it worse.
Let's discuss today in person. Comment on attachment 286688 [details]
Patch
r=me. Looks like getting the spec changed back is going to be difficult.
Comment on attachment 286688 [details] Patch Rejecting attachment 286688 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 286688, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: Log Hunk #1 succeeded at 1 with fuzz 3. patching file LayoutTests/imported/w3c/web-platform-tests/dom/lists/DOMTokenList-stringifier-expected.txt patching file LayoutTests/imported/w3c/web-platform-tests/dom/lists/DOMTokenList-value-expected.txt patching file LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Element-classlist-expected.txt Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Chris Dumez']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/1956506 Ryosuke, I think we can land this, no? (In reply to comment #7) > Ryosuke, I think we can land this, no? Oh, I didn't realize that this patch hadn't been landed. I guess CQ failed? (In reply to comment #8) > (In reply to comment #7) > > Ryosuke, I think we can land this, no? > > Oh, I didn't realize that this patch hadn't been landed. I guess CQ failed? Looks like the CQ failed because the patch needs rebasing, yes. (In reply to comment #9) > (In reply to comment #8) > > (In reply to comment #7) > > > Ryosuke, I think we can land this, no? > > > > Oh, I didn't realize that this patch hadn't been landed. I guess CQ failed? > > Looks like the CQ failed because the patch needs rebasing, yes. Okay, let me rebase & land it tomorrow morning. Or feel free to land it if you'd like. Committed r206560: <http://trac.webkit.org/changeset/206560> |