Bug 161061

Summary: Drop TextTrackCue's constructor as per the latest specification
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: DOMAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, darin, eric.carlson, jer.noble, rniwa, sam
Priority: P2 Keywords: WebExposed
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
URL: https://html.spec.whatwg.org/#texttrackcue
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews126 for ios-simulator-elcapitan-wk2
none
Patch none

Chris Dumez
Reported 2016-08-22 15:34:41 PDT
Drop TextTrackCue's constructor as per the latest specification: - https://html.spec.whatwg.org/#texttrackcue Firefox and Chrome do not have this constructor.
Attachments
Patch (45.17 KB, patch)
2016-08-22 16:09 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews126 for ios-simulator-elcapitan-wk2 (689.71 KB, application/zip)
2016-08-22 19:12 PDT, Build Bot 		no flags
Details
Patch (47.99 KB, patch)
2016-08-22 19:23 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2016-08-22 15:38:21 PDT
Blink's intent to remove: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/R34xpMQGtXU/XwXsi85Y7acJ
Chris Dumez
Comment 2 2016-08-22 15:40:17 PDT
People should use the VTTCue constructor instead, which we support.
Chris Dumez
Comment 3 2016-08-22 16:09:21 PDT
Created attachment 286635 [details] Patch
Build Bot
Comment 4 2016-08-22 19:12:42 PDT
Comment on attachment 286635 [details] Patch Attachment 286635 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/1924529 New failing tests: js/dom/constructor-length.html
Build Bot
Comment 5 2016-08-22 19:12:45 PDT
Created attachment 286648 [details] Archive of layout-test-results from ews126 for ios-simulator-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews126 Port: ios-simulator-elcapitan-wk2 Platform: Mac OS X 10.11.5
Chris Dumez
Comment 6 2016-08-22 19:23:28 PDT
Created attachment 286652 [details] Patch
WebKit Commit Bot
Comment 7 2016-08-22 23:45:49 PDT
Comment on attachment 286652 [details] Patch Clearing flags on attachment: 286652 Committed r204765: <http://trac.webkit.org/changeset/204765>
WebKit Commit Bot
Comment 8 2016-08-22 23:45:54 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.