Bug 161041

Summary: [ES6] Module should not allow HTML comments
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, fpizlo, ggaren, keith_miller, mark.lam, msaboff, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch saam: review+

Yusuke Suzuki
Reported 2016-08-21 22:14:35 PDT
[ES6] Module should not allow HTML comments
Attachments
Patch (48.95 KB, patch)
2016-08-21 22:30 PDT, Yusuke Suzuki 		saam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2016-08-21 22:30:41 PDT
Created attachment 286586 [details] Patch
Saam Barati
Comment 2 2016-08-22 00:12:41 PDT
Comment on attachment 286586 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=286586&action=review > Source/JavaScriptCore/parser/ParserModes.h:36 > +enum class JSParserScriptMode { Classic, Module }; I propose calling this "JSParserCommentMode" or something to better indicate its use case.
Yusuke Suzuki
Comment 3 2016-08-22 06:47:13 PDT
Comment on attachment 286586 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=286586&action=review Thanks! >> Source/JavaScriptCore/parser/ParserModes.h:36 >> +enum class JSParserScriptMode { Classic, Module }; > > I propose calling this "JSParserCommentMode" or something to better indicate its use case. Sounds nice. Fixed.
Yusuke Suzuki
Comment 4 2016-08-22 07:13:56 PDT
Committed r204714: <http://trac.webkit.org/changeset/204714>
Note You need to log in before you can comment on or make changes to this bug.