Bug 161028

Summary: Rename CustomElementsRegistry to CustomElementRegistry
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: DOMAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, joepeck, kling, koivisto, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 154907    
Attachments:
Description Flags
Does the rename darin: review+, commit-queue: commit-queue-

Description Ryosuke Niwa 2016-08-19 22:25:50 PDT
We don't use plurals for NodeList, StyleSheetList, CSSRuleList, etc...
We should rename CustomElement*s*Registry to CustomElementsRegistry.

Filed https://github.com/w3c/webcomponents/issues/548 to change the specification.
Comment 1 Ryosuke Niwa 2016-08-19 22:35:41 PDT
Created attachment 286529 [details]
Does the rename
Comment 2 WebKit Commit Bot 2016-08-21 03:02:09 PDT
Comment on attachment 286529 [details]
Does the rename

Rejecting attachment 286529 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 286529, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
atform/mac-wk1/js/dom/global-constructors-attributes-expected.txt
patching file LayoutTests/platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt
patching file LayoutTests/platform/mac/js/dom/global-constructors-attributes-expected.txt
patching file LayoutTests/platform/win/js/dom/global-constructors-attributes-expected.txt

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Darin Adler']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/1914777
Comment 3 Ryosuke Niwa 2016-08-22 12:46:43 PDT
Committed r204732: <http://trac.webkit.org/changeset/204732>
Comment 4 Ryosuke Niwa 2016-09-01 16:17:25 PDT
<rdar://problem/28090378>