WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
161028
Rename CustomElementsRegistry to CustomElementRegistry
https://bugs.webkit.org/show_bug.cgi?id=161028
Summary
Rename CustomElementsRegistry to CustomElementRegistry
Ryosuke Niwa
Reported
2016-08-19 22:25:50 PDT
We don't use plurals for NodeList, StyleSheetList, CSSRuleList, etc... We should rename CustomElement*s*Registry to CustomElementsRegistry. Filed
https://github.com/w3c/webcomponents/issues/548
to change the specification.
Attachments
Does the rename
(105.41 KB, patch)
2016-08-19 22:35 PDT
,
Ryosuke Niwa
darin
: review+
commit-queue
: commit-queue-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1
2016-08-19 22:35:41 PDT
Created
attachment 286529
[details]
Does the rename
WebKit Commit Bot
Comment 2
2016-08-21 03:02:09 PDT
Comment on
attachment 286529
[details]
Does the rename Rejecting
attachment 286529
[details]
from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 286529, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: atform/mac-wk1/js/dom/global-constructors-attributes-expected.txt patching file LayoutTests/platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt patching file LayoutTests/platform/mac/js/dom/global-constructors-attributes-expected.txt patching file LayoutTests/platform/win/js/dom/global-constructors-attributes-expected.txt Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Darin Adler']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output:
http://webkit-queues.webkit.org/results/1914777
Ryosuke Niwa
Comment 3
2016-08-22 12:46:43 PDT
Committed
r204732
: <
http://trac.webkit.org/changeset/204732
>
Ryosuke Niwa
Comment 4
2016-09-01 16:17:25 PDT
<
rdar://problem/28090378
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug