Bug 161028 - Rename CustomElementsRegistry to CustomElementRegistry
Summary: Rename CustomElementsRegistry to CustomElementRegistry
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
Keywords: InRadar
Depends on:
Blocks: 154907
  Show dependency treegraph
Reported: 2016-08-19 22:25 PDT by Ryosuke Niwa
Modified: 2016-09-01 16:17 PDT (History)
7 users (show)

See Also:

Does the rename (105.41 KB, patch)
2016-08-19 22:35 PDT, Ryosuke Niwa
darin: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2016-08-19 22:25:50 PDT
We don't use plurals for NodeList, StyleSheetList, CSSRuleList, etc...
We should rename CustomElement*s*Registry to CustomElementsRegistry.

Filed https://github.com/w3c/webcomponents/issues/548 to change the specification.
Comment 1 Ryosuke Niwa 2016-08-19 22:35:41 PDT
Created attachment 286529 [details]
Does the rename
Comment 2 WebKit Commit Bot 2016-08-21 03:02:09 PDT
Comment on attachment 286529 [details]
Does the rename

Rejecting attachment 286529 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 286529, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
patching file LayoutTests/platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt
patching file LayoutTests/platform/mac/js/dom/global-constructors-attributes-expected.txt
patching file LayoutTests/platform/win/js/dom/global-constructors-attributes-expected.txt

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Darin Adler']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/1914777
Comment 3 Ryosuke Niwa 2016-08-22 12:46:43 PDT
Committed r204732: <http://trac.webkit.org/changeset/204732>
Comment 4 Ryosuke Niwa 2016-09-01 16:17:25 PDT