|Summary:||AX: iOS, Wrong axLabel on static text if heading has multiple children|
|Product:||WebKit||Reporter:||Nan Wang <n_wang>|
|Severity:||Normal||CC:||aboxhall, apinheiro, cfleizach, commit-queue, dmazzoni, jcraig, jdiggs, mario, n_wang, samuel_white, webkit-bug-importer|
|Version:||WebKit Nightly Build|
Description Nan Wang 2016-08-18 16:35:56 PDT
When heading has multiple children, each static text child seems to have the axLabel to be the concatenation of all the heading children's labels. <rdar://problem/27827108>
Comment 2 Build Bot 2016-08-18 18:58:49 PDT
Comment on attachment 286414 [details] Patch Attachment 286414 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/1895740 New failing tests: fast/scrolling/ios/scroll-events-back-forward.html
Comment 3 Build Bot 2016-08-18 18:58:52 PDT
Created attachment 286429 [details] Archive of layout-test-results from ews122 for ios-simulator-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-elcapitan-wk2 Platform: Mac OS X 10.11.5
Comment 4 Nan Wang 2016-08-18 23:40:51 PDT
Comment on attachment 286414 [details] Patch test failure is not related to this patch.
Comment 5 chris fleizach 2016-08-19 09:01:00 PDT
Comment on attachment 286414 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=286414&action=review > Source/WebCore/ChangeLog:9 > + no alternate texts. So we shouldn't use accessibilityLable to check for user defined texts no alternate "text." - text is already plural here accessibilityLable -> accessibilityLabel this description isn't very clear to me... what is the problem with calling axLabel? what does it return, that baseDescription does not > LayoutTests/accessibility/ios-simulator/heading-with-aria-label.html:40 > + // Also make sure when the heading has multiple children, we are not messing up with "messing up" is too colloquial here. I would say "When a heading has multiple children, ensure ..."
Comment 6 Nan Wang 2016-08-19 10:34:14 PDT
Created attachment 286457 [details] Patch Update from review
Comment 7 WebKit Commit Bot 2016-08-19 12:25:09 PDT
Comment on attachment 286457 [details] Patch Clearing flags on attachment: 286457 Committed r204645: <http://trac.webkit.org/changeset/204645>
Comment 8 WebKit Commit Bot 2016-08-19 12:25:14 PDT
All reviewed patches have been landed. Closing bug.