Bug 160968

Summary: Add LLINT probe() macro for X86_64.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, keith_miller, msaboff, saam
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch. ggaren: review+

Mark Lam
Reported 2016-08-18 12:06:13 PDT
Patch coming.
Attachments
proposed patch. (2.24 KB, patch)
2016-08-18 12:09 PDT, Mark Lam
ggaren: review+
Mark Lam
Comment 1 2016-08-18 12:09:42 PDT
Created attachment 286384 [details] proposed patch.
Geoffrey Garen
Comment 2 2016-08-18 12:55:52 PDT
Comment on attachment 286384 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=286384&action=review r=me > Source/JavaScriptCore/llint/LowLevelInterpreter.asm:466 > + push a0, a1 > + push a2, a3 > + push t0, t1 > + push t2, t3 > + push t4, t5 This looks unaligned. Please fix.
Mark Lam
Comment 3 2016-08-18 13:10:20 PDT
Comment on attachment 286384 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=286384&action=review Thanks for the review. Will land shortly. >> Source/JavaScriptCore/llint/LowLevelInterpreter.asm:466 >> + push t4, t5 > > This looks unaligned. Please fix. These are pushing 5 pairs of registers. Since the alignment requirement is 16 bytes (i.e. the size of 2 registers), the required alignment is preserved.
Mark Lam
Comment 4 2016-08-18 13:27:53 PDT
Note You need to log in before you can comment on or make changes to this bug.