Bug 160964

Summary:

[Cocoa] Add SPI to WKProcessPool for enabling cookie storage partitioning

Product:

WebKit

Reporter:

Andy Estes <aestes>

Component:

New Bugs

Assignee:

Andy Estes <aestes>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, andersca, beidson, bfulgham, cdumez, commit-queue, sam, thorton

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=160966

Attachments:

Description	Flags
Patch	none
Follow SPI naming guidelines	andersca: review+, aestes: commit-queue-
Patch for landing	none

Andy Estes

Reported 2016-08-18 11:21:11 PDT

[Cocoa] Add SPI to WKProcessPool for enabling cookie storage partitioning

Attachments
Patch (16.49 KB, patch) 2016-08-18 11:30 PDT, Andy Estes	no flags	Details Formatted Diff Diff
Follow SPI naming guidelines (2.77 KB, patch) 2016-08-18 12:22 PDT, Andy Estes	andersca: review+ aestes: commit-queue-	Details Formatted Diff Diff
Patch for landing (2.82 KB, patch) 2016-08-18 12:35 PDT, Andy Estes	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Andy Estes

Comment 1 2016-08-18 11:30:12 PDT

Created attachment 286378 [details] Patch

Brent Fulgham

Comment 2 2016-08-18 11:38:32 PDT

Comment on attachment 286378 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=286378&action=review It seems like we should have some TestWebKitAPI tests for this. Can you file a bug to create such a thing if they don't already exist? > Source/WebCore/page/Settings.h:27 > +#pragma once Nice! > Source/WebCore/platform/network/cf/NetworkStorageSessionCFNet.cpp:43 > +static bool cookieStoragePartitioningEnabled; Are you sure we don't want to initialize this to false just to avoid flakiness?

Andy Estes

Comment 3 2016-08-18 11:44:06 PDT

(In reply to comment #2) > Comment on attachment 286378 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=286378&action=review > > It seems like we should have some TestWebKitAPI tests for this. Can you file > a bug to create such a thing if they don't already exist? Agreed. I filed <https://bugs.webkit.org/show_bug.cgi?id=160966>. > > > Source/WebCore/page/Settings.h:27 > > +#pragma once > > Nice! > > > Source/WebCore/platform/network/cf/NetworkStorageSessionCFNet.cpp:43 > > +static bool cookieStoragePartitioningEnabled; > > Are you sure we don't want to initialize this to false just to avoid > flakiness? Static variables are implicitly initialized to 0 (false). Thanks for the review!

WebKit Commit Bot

Comment 4 2016-08-18 12:00:58 PDT

Comment on attachment 286378 [details] Patch Clearing flags on attachment: 286378 Committed r204603: <http://trac.webkit.org/changeset/204603>

WebKit Commit Bot

Comment 5 2016-08-18 12:01:03 PDT

All reviewed patches have been landed. Closing bug.

Anders Carlsson

Comment 6 2016-08-18 12:08:44 PDT

This needs to follow the SPI guidelines. Please prefix the setter/getter with an underscore.

Andy Estes

Comment 7 2016-08-18 12:22:42 PDT

Reopening to attach new patch.

Andy Estes

Comment 8 2016-08-18 12:22:45 PDT

Created attachment 286389 [details] Follow SPI naming guidelines

Andy Estes

Comment 9 2016-08-18 12:35:52 PDT

Created attachment 286390 [details] Patch for landing

WebKit Commit Bot

Comment 10 2016-08-18 12:57:19 PDT

Comment on attachment 286390 [details] Patch for landing Clearing flags on attachment: 286390 Committed r204606: <http://trac.webkit.org/changeset/204606>

WebKit Commit Bot

Comment 11 2016-08-18 12:57:24 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.