Bug 160957

Summary: [MediaStream] cleanup MediaConstraints
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: MediaAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch. none

Eric Carlson
Reported 2016-08-18 07:45:02 PDT
Have MediaConstraints hold a constraint type enum rather than a string so the conversion only happens one time. Also make the RealtimeMediaSourceSupportedConstraints::constraintFromName and RealtimeMediaSourceSupportedConstraints::nameForConstraint methods static.
Attachments
Proposed patch. (24.38 KB, patch)
2016-08-18 07:52 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Carlson
Comment 1 2016-08-18 07:52:18 PDT
Created attachment 286368 [details] Proposed patch.
Antoine Quint
Comment 2 2016-08-18 08:02:11 PDT
Comment on attachment 286368 [details] Proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=286368&action=review > Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:212 > + LOG(Media, "AVVideoCaptureSource::applyConstraints(%p), unable set frame rate to %f", this, frameRate.value()); Do we need this new log?
Eric Carlson
Comment 3 2016-08-18 08:06:29 PDT
(In reply to comment #2) > Comment on attachment 286368 [details] > Proposed patch. > > View in context: > https://bugs.webkit.org/attachment.cgi?id=286368&action=review > > > Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:212 > > + LOG(Media, "AVVideoCaptureSource::applyConstraints(%p), unable set frame rate to %f", this, frameRate.value()); > > Do we need this new log? We don't need it, but I think it is useful because it logs an error that may otherwise be difficult to track down.
WebKit Commit Bot
Comment 4 2016-08-18 09:07:57 PDT
Comment on attachment 286368 [details] Proposed patch. Clearing flags on attachment: 286368 Committed r204595: <http://trac.webkit.org/changeset/204595>
WebKit Commit Bot
Comment 5 2016-08-18 09:08:01 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.