Bug 160943

Summary: Extra logging for crash reason
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Enhancement CC: ap, commit-queue, glenn, lforschler
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Jonathan Bedard
Reported 2016-08-17 10:33:00 PDT
In some cases, a process is marked as 'crashed' but does not produce a crash-log. This would indicate that the process in question did not 'crash,' but rather was marked as having crashed for some reason. This extra logging should aid in diagnosing these falsely marked crashes.
Attachments
Patch (2.59 KB, patch)
2016-08-17 10:40 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (2.73 KB, patch)
2016-08-17 10:51 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jonathan Bedard
Comment 1 2016-08-17 10:40:33 PDT
Created attachment 286306 [details] Patch
Alexey Proskuryakov
Comment 2 2016-08-17 10:42:45 PDT
Comment on attachment 286306 [details] Patch r=me, please polish the sentences to make them complete though.
Jonathan Bedard
Comment 3 2016-08-17 10:51:32 PDT
Created attachment 286307 [details] Patch
WebKit Commit Bot
Comment 4 2016-08-17 11:29:23 PDT
Comment on attachment 286307 [details] Patch Rejecting attachment 286307 [details] from commit-queue. jbedard@apple.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights.
WebKit Commit Bot
Comment 5 2016-08-17 15:20:12 PDT
Comment on attachment 286307 [details] Patch Clearing flags on attachment: 286307 Committed r204577: <http://trac.webkit.org/changeset/204577>
WebKit Commit Bot
Comment 6 2016-08-17 15:20:16 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.