Bug 160943 - Extra logging for crash reason
Summary: Extra logging for crash reason
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Enhancement
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-08-17 10:33 PDT by Jonathan Bedard
Modified: 2016-08-17 15:20 PDT (History)
4 users (show)

See Also:


Attachments
Patch (2.59 KB, patch)
2016-08-17 10:40 PDT, Jonathan Bedard
no flags Details | Formatted Diff | Diff
Patch (2.73 KB, patch)
2016-08-17 10:51 PDT, Jonathan Bedard
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2016-08-17 10:33:00 PDT
In some cases, a process is marked as 'crashed' but does not produce a crash-log.  This would indicate that the process in question did not 'crash,' but rather was marked as having crashed for some reason.  This extra logging should aid in diagnosing these falsely marked crashes.
Comment 1 Jonathan Bedard 2016-08-17 10:40:33 PDT
Created attachment 286306 [details]
Patch
Comment 2 Alexey Proskuryakov 2016-08-17 10:42:45 PDT
Comment on attachment 286306 [details]
Patch

r=me, please polish the sentences to make them complete though.
Comment 3 Jonathan Bedard 2016-08-17 10:51:32 PDT
Created attachment 286307 [details]
Patch
Comment 4 WebKit Commit Bot 2016-08-17 11:29:23 PDT
Comment on attachment 286307 [details]
Patch

Rejecting attachment 286307 [details] from commit-queue.

jbedard@apple.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.
Comment 5 WebKit Commit Bot 2016-08-17 15:20:12 PDT
Comment on attachment 286307 [details]
Patch

Clearing flags on attachment: 286307

Committed r204577: <http://trac.webkit.org/changeset/204577>
Comment 6 WebKit Commit Bot 2016-08-17 15:20:16 PDT
All reviewed patches have been landed.  Closing bug.