Bug 160923

Summary: Rename didLayout(LayoutMilestones) to didReachLayoutMilestone(), and related WK2 functions
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, cdumez, commit-queue, esprehn+autocc, japhet, kangil.han, mitz, simon.fraser, thorton
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch thorton: review+

Simon Fraser (smfr)
Reported 2016-08-16 17:24:59 PDT
Rename didLayout(LayoutMilestones) to didReachLayoutMilestone(), and related WK2 functions
Attachments
Patch (31.81 KB, patch)
2016-08-16 17:27 PDT, Simon Fraser (smfr) 		thorton: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2016-08-16 17:27:56 PDT
Created attachment 286238 [details] Patch
WebKit Commit Bot
Comment 2 2016-08-16 17:30:05 PDT
Attachment 286238 [details] did not pass style-queue: ERROR: Source/WebKit/win/ChangeLog:8: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebKit/win/ChangeLog:9: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebKit2/ChangeLog:8: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebKit2/ChangeLog:9: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebKit2/ChangeLog:10: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebKit2/ChangeLog:11: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebCore/ChangeLog:8: Line contains tab character. [whitespace/tab] [5] ERROR: Source/WebCore/ChangeLog:9: Line contains tab character. [whitespace/tab] [5] Total errors found: 8 in 33 files If any of these errors are false positives, please file a bug against check-webkit-style.
Tim Horton
Comment 3 2016-08-16 17:32:41 PDT
Comment on attachment 286238 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=286238&action=review > Source/WebCore/ChangeLog:8 > + didLayout(LayoutMilestones) -> didReachLayoutMilestone(LayoutMilestones) Tabs?
Simon Fraser (smfr)
Comment 4 2016-08-19 11:51:28 PDT
https://trac.webkit.org/r204637
Note You need to log in before you can comment on or make changes to this bug.