Bug 160919

Summary: Add support for ShadowRoot.mode attribute
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: DOMAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, rniwa
Priority: P2 Keywords: WebExposed
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
URL: https://dom.spec.whatwg.org/#interface-shadowroot
Bug Depends on:    
Bug Blocks: 148695    
Attachments:
Description Flags
Patch
none
Patch none

Description Chris Dumez 2016-08-16 16:14:54 PDT
Add support for ShadowRoot.mode attribute:
- https://dom.spec.whatwg.org/#interface-shadowroot
Comment 1 Chris Dumez 2016-08-16 16:26:23 PDT
Created attachment 286230 [details]
Patch
Comment 2 Ryosuke Niwa 2016-08-16 16:54:45 PDT
Comment on attachment 286230 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=286230&action=review

> Source/WebCore/dom/ShadowRoot.idl:37
> +enum ShadowRootMode { "user-agent", "closed", "open" };

Maybe we should add a comment that "user-agent" is a WebKit extension that should never be exposed to the Web?
Comment 3 Chris Dumez 2016-08-16 16:56:42 PDT
Created attachment 286234 [details]
Patch
Comment 4 WebKit Commit Bot 2016-08-16 17:27:12 PDT
Comment on attachment 286234 [details]
Patch

Clearing flags on attachment: 286234

Committed r204543: <http://trac.webkit.org/changeset/204543>
Comment 5 WebKit Commit Bot 2016-08-16 17:27:17 PDT
All reviewed patches have been landed.  Closing bug.