Bug 160900

Summary: Removed Objective-C specific attributes from IDL, made conditionals more consistent
Product: WebKit Reporter: Darin Adler <darin>
Component: BindingsAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, cdumez, sam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Darin Adler
Reported 2016-08-16 08:49:10 PDT
Removed Objective-C specific attributes from IDL, made conditionals more consistent
Attachments
Patch (116.88 KB, patch)
2016-08-16 08:53 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
Patch (108.97 KB, patch)
2016-08-20 18:05 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
Patch (108.96 KB, patch)
2016-08-20 18:19 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
Patch (109.70 KB, patch)
2016-08-20 19:07 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2016-08-16 08:53:29 PDT
Created attachment 286177 [details] Patch
Darin Adler
Comment 2 2016-08-18 14:24:50 PDT
Comment on attachment 286177 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=286177&action=review > Source/WebCore/dom/KeyboardEvent.idl:59 > + optional boolean shiftKey = false, optional boolean metaKey = false, Oops, this should end with "optional boolean altGraphKey = false);" and I think that’s why all the builds are failing!
Darin Adler
Comment 3 2016-08-20 18:05:07 PDT
Created attachment 286547 [details] Patch
Darin Adler
Comment 4 2016-08-20 18:05:34 PDT
Hey Sam, looks like you just did this, so my new patch is much reduced after merging with your change.
Darin Adler
Comment 5 2016-08-20 18:19:37 PDT
Created attachment 286548 [details] Patch
Sam Weinig
Comment 6 2016-08-20 18:31:34 PDT
Comment on attachment 286548 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=286548&action=review > Source/WebCore/dom/Node.idl:75 > + readonly attribute DOMString? namespaceURI; > + [SetterRaisesException] attribute DOMString? prefix; > + readonly attribute DOMString? localName; These seem to be additions. I think these may have moved to element recently-isa.
Darin Adler
Comment 7 2016-08-20 19:03:51 PDT
Oops, they did move to Attr and Element. Let me fix that.
Darin Adler
Comment 8 2016-08-20 19:07:47 PDT
Created attachment 286549 [details] Patch
Darin Adler
Comment 9 2016-08-20 19:23:39 PDT
Committed r204687: <http://trac.webkit.org/changeset/204687>
Note You need to log in before you can comment on or make changes to this bug.