Bug 160888

Summary:

Simplify SocketStreamError

Product:

WebKit

Reporter:

Alex Christensen <achristensen>

Component:

New Bugs

Assignee:

Alex Christensen <achristensen>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

Description Alex Christensen 2016-08-15 19:53:57 PDT

Simplify SocketStreamError

Comment 1 Alex Christensen 2016-08-15 19:55:49 PDT

Created attachment 286139 [details]
Patch

Comment 2 Alex Christensen 2016-08-15 20:39:05 PDT

Created attachment 286144 [details]
Patch

Comment 3 Darin Adler 2016-08-15 23:02:37 PDT

Comment on attachment 286144 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=286144&action=review

> Source/WebCore/platform/network/soup/SocketStreamHandleImplSoup.cpp:117
> +        handle->didFail(SocketStreamError(error->code, String(), String(error->message)));

Do we really need to cast the second thing to String?

Comment 4 Alex Christensen 2016-08-16 00:17:43 PDT

Created attachment 286159 [details]
Patch

Comment 5 WebKit Commit Bot 2016-08-16 00:56:47 PDT

Comment on attachment 286159 [details]
Patch

Clearing flags on attachment: 286159

Committed r204501: <http://trac.webkit.org/changeset/204501>

Comment 6 WebKit Commit Bot 2016-08-16 00:56:52 PDT

All reviewed patches have been landed.  Closing bug.