Bug 160888

Summary: Simplify SocketStreamError
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Alex Christensen
Reported 2016-08-15 19:53:57 PDT
Simplify SocketStreamError
Attachments
Patch (31.04 KB, patch)
2016-08-15 19:55 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (32.76 KB, patch)
2016-08-15 20:39 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (32.78 KB, patch)
2016-08-16 00:17 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2016-08-15 19:55:49 PDT
Created attachment 286139 [details] Patch
Alex Christensen
Comment 2 2016-08-15 20:39:05 PDT
Created attachment 286144 [details] Patch
Darin Adler
Comment 3 2016-08-15 23:02:37 PDT
Comment on attachment 286144 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=286144&action=review > Source/WebCore/platform/network/soup/SocketStreamHandleImplSoup.cpp:117 > + handle->didFail(SocketStreamError(error->code, String(), String(error->message))); Do we really need to cast the second thing to String?
Alex Christensen
Comment 4 2016-08-16 00:17:43 PDT
Created attachment 286159 [details] Patch
WebKit Commit Bot
Comment 5 2016-08-16 00:56:47 PDT
Comment on attachment 286159 [details] Patch Clearing flags on attachment: 286159 Committed r204501: <http://trac.webkit.org/changeset/204501>
WebKit Commit Bot
Comment 6 2016-08-16 00:56:52 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.