Bug 160885

Summary: Web Inspector: Select elements in DOM hierarchy are misaligned
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
[Image] After Patch is applied none

Devin Rousso
Reported 2016-08-15 18:00:32 PDT
It seems to be horizontally offset by a few pixels. Very irksome...
Attachments
Patch (1.32 KB, patch)
2016-08-15 18:01 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Patch (1.32 KB, patch)
2016-08-16 23:00 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
[Image] After Patch is applied (757.15 KB, image/gif)
2016-08-17 13:52 PDT, Devin Rousso 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-08-15 18:00:47 PDT
<rdar://problem/27858089>
Devin Rousso
Comment 2 2016-08-15 18:01:33 PDT
Created attachment 286126 [details] Patch
Matt Baker
Comment 3 2016-08-15 18:46:56 PDT
No screenshot?! (╯°□°）╯︵ ┻━┻
Joseph Pecoraro
Comment 4 2016-08-15 20:08:08 PDT
Comment on attachment 286126 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=286126&action=review > Source/WebInspectorUI/UserInterface/Views/HierarchicalPathComponent.css:100 > - left: 10px; > + left: 12px; We should be very specific here: • On my Non-retina OS X El Capitan machine this needs to be left: 13px to align perfectly with the text. • On my Retina macOS Sierra machine this needs to be left: 13px to align perfectly with the text. What system were you on where 12px was optimal. Maybe we need to make platform/configuration specific values? Or maybe there is a system setting that nudges it 1px for you?
Devin Rousso
Comment 5 2016-08-16 23:00:25 PDT
Created attachment 286278 [details] Patch
Devin Rousso
Comment 6 2016-08-16 23:04:00 PDT
(In reply to comment #4) > We should be very specific here: > > • On my Non-retina OS X El Capitan machine this needs to be left: 13px to > align perfectly with the text. > • On my Retina macOS Sierra machine this needs to be left: 13px to align > perfectly with the text. > > What system were you on where 12px was optimal. Maybe we need to make > platform/configuration specific values? Or maybe there is a system setting > that nudges it 1px for you? Not really sure why, but it looked right when I tried it yesterday. I tried moving the window around and changing resolution, but 13px always looked exactly right ¯\_(ツ)_/¯
Devin Rousso
Comment 7 2016-08-17 13:52:37 PDT
Created attachment 286326 [details] [Image] After Patch is applied
Timothy Hatcher
Comment 8 2016-08-17 14:01:22 PDT
Comment on attachment 286278 [details] Patch Yes!
WebKit Commit Bot
Comment 9 2016-08-17 14:22:37 PDT
Comment on attachment 286278 [details] Patch Clearing flags on attachment: 286278 Committed r204571: <http://trac.webkit.org/changeset/204571>
WebKit Commit Bot
Comment 10 2016-08-17 14:22:41 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.