Bug 160882

Summary: webkitpy error in TestRunResults.merge()
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, glenn
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Simon Fraser (smfr)
Reported 2016-08-15 17:14:28 PDT
webkitpy error in TestRunResults.merge()
Attachments
Patch (1.64 KB, patch)
2016-08-15 17:16 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2016-08-15 17:16:03 PDT
Created attachment 286122 [details] Patch
Daniel Bates
Comment 2 2016-08-15 17:18:12 PDT
Comment on attachment 286122 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=286122&action=review > Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py:100 > def merge(self, test_run_results): > + if not test_run_results: > + return self > # self.expectations should be the same for both > self.total += test_run_results.total We should consider writing a test for this logic.
Alexey Proskuryakov
Comment 3 2016-08-15 22:54:59 PDT
Comment on attachment 286122 [details] Patch cq+ to unbreak EWS.
WebKit Commit Bot
Comment 4 2016-08-15 23:43:10 PDT
Comment on attachment 286122 [details] Patch Clearing flags on attachment: 286122 Committed r204498: <http://trac.webkit.org/changeset/204498>
WebKit Commit Bot
Comment 5 2016-08-15 23:43:15 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.