Bug 160872

Summary:

Web Inspector: Make an icon for Code Coverage Profiler

Product:

WebKit

Reporter:

Nikita Vasilyev <nvasilyev>

Component:

Web Inspector

Assignee:

Nikita Vasilyev <nvasilyev>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

agomez, bburg, commit-queue, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

160973

Attachments:

Description	Flags
Patch	joepeck: review+, joepeck: commit-queue-
[Image] C icon	none
[Image] C icon @1x	none
Patch	none

Nikita Vasilyev

Reported 2016-08-15 15:42:32 PDT

This icon should be right next to [T] icon, that toggles Type Profiler.

Attachments
Patch (1.45 KB, patch) 2016-08-18 16:50 PDT, Nikita Vasilyev	joepeck: review+ joepeck: commit-queue-	Details Formatted Diff Diff
[Image] C icon (14.39 KB, image/png) 2016-08-18 16:50 PDT, Nikita Vasilyev	no flags	Details
[Image] C icon @1x (4.03 KB, image/png) 2016-08-19 12:19 PDT, Nikita Vasilyev	no flags	Details
Patch (1.46 KB, patch) 2016-08-19 12:24 PDT, Nikita Vasilyev	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2016-08-15 15:43:07 PDT

<rdar://problem/27855650>

Nikita Vasilyev

Comment 2 2016-08-18 16:50:14 PDT

Created attachment 286412 [details] Patch

Nikita Vasilyev

Comment 3 2016-08-18 16:50:42 PDT

Created attachment 286413 [details] [Image] C icon

Nikita Vasilyev

Comment 4 2016-08-18 17:02:26 PDT

To answer possible copyright questions: I drew this "C" in Photoshop. I didn't use any existing fonts.

Joseph Pecoraro

Comment 5 2016-08-18 17:56:40 PDT

Comment on attachment 286412 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=286412&action=review Looks good! I assume you took a look on non-Retain too and it looked fine? File name is a bit weird. "Code Coverage" seems better than "Control Flow". > Source/WebInspectorUI/UserInterface/Images/NavigationItemControlFlow.svg:5 > + <path fill="none" stroke="currentColor" stroke-width="1" d="M9,5.5s0-1.5-2.5-1.5C3,4,3,10,6.5,10c2.5,0,2.5-1.5,2.5-1.5"/> This style for path is to use spaces not commas.

Nikita Vasilyev

Comment 6 2016-08-19 12:19:34 PDT

Created attachment 286467 [details] [Image] C icon @1x Pixel hinting isn't great, but I'd rather land this first and polish it later if we decide to stick with this icon.

Nikita Vasilyev

Comment 7 2016-08-19 12:24:12 PDT

Created attachment 286468 [details] Patch

WebKit Commit Bot

Comment 8 2016-08-19 12:35:02 PDT

Comment on attachment 286468 [details] Patch Clearing flags on attachment: 286468 Committed r204646: <http://trac.webkit.org/changeset/204646>

WebKit Commit Bot

Comment 9 2016-08-19 12:35:07 PDT

All reviewed patches have been landed. Closing bug.

Nikita Vasilyev

Comment 10 2016-08-19 13:10:57 PDT

(In reply to comment #5) > File name is a bit weird. "Code Coverage" seems better than "Control Flow". We have RuntimeAgent.enableControlFlowProfiler. Are you okay with this name? Or should it be enableCodeCoverageProfiler?

Joseph Pecoraro

Comment 11 2016-08-19 15:34:14 PDT

(In reply to comment #10) > (In reply to comment #5) > > File name is a bit weird. "Code Coverage" seems better than "Control Flow". > > We have RuntimeAgent.enableControlFlowProfiler. Are you okay with this name? > Or should it be enableCodeCoverageProfiler? I think code coverage profiler is better.

Note You need to log in before you can comment on or make changes to this bug.