Bug 160858

Summary:

Rename SocketStreamHandleBase to SocketStreamHandle and SocketStreamHandle to SocketStreamHandleImpl

Product:

WebKit

Reporter:

Alex Christensen <achristensen>

Component:

New Bugs

Assignee:

Alex Christensen <achristensen>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, commit-queue

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	beidson: review+

Alex Christensen

Reported 2016-08-15 12:46:34 PDT

Rename SocketStreamHandleBase to SocketStreamHandle and SocketStreamHandle to SocketStreamHandleImpl

Attachments
Patch (185.52 KB, patch) 2016-08-15 12:49 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (188.07 KB, patch) 2016-08-15 13:00 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (188.22 KB, patch) 2016-08-15 13:15 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (188.58 KB, patch) 2016-08-15 13:27 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (189.60 KB, patch) 2016-08-15 13:36 PDT, Alex Christensen	beidson: review+	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Alex Christensen

Comment 1 2016-08-15 12:49:46 PDT

Created attachment 286078 [details] Patch

WebKit Commit Bot

Comment 2 2016-08-15 12:51:51 PDT

Attachment 286078 [details] did not pass style-queue: ERROR: Source/WebCore/platform/network/cf/SocketStreamHandleImpl.h:64: The parameter name "error" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/platform/network/cf/SocketStreamHandleImpl.h:101: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/platform/network/SocketStreamHandle.cpp:38: Omit int when using unsigned [runtime/unsigned] [1] ERROR: Source/WebCore/platform/network/SocketStreamHandle.cpp:124: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/platform/network/soup/SocketStreamHandleImpl.h:81: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/platform/network/soup/SocketStreamHandleImplSoup.cpp:37: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/platform/network/SocketStreamHandle.h:68: One space before end of line comments [whitespace/comments] [5] ERROR: Source/WebCore/platform/network/cf/SocketStreamHandleImplCFNet.cpp:54: "CFNetwork/CFNetwork.h" already included at Source/WebCore/platform/network/cf/SocketStreamHandleImplCFNet.cpp:49 [build/include] [4] ERROR: Source/WebCore/platform/network/cf/SocketStreamHandleImplCFNet.cpp:148: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/cf/SocketStreamHandleImplCFNet.cpp:169: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/platform/network/cf/SocketStreamHandleImplCFNet.cpp:173: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/platform/network/cf/SocketStreamHandleImplCFNet.cpp:487: Missing space before ( in switch( [whitespace/parens] [5] ERROR: Source/WebCore/platform/network/cf/SocketStreamHandleImplCFNet.cpp:559: Missing space before ( in switch( [whitespace/parens] [5] ERROR: Source/WebCore/platform/network/cf/SocketStreamHandleImplCFNet.cpp:700: One space before end of line comments [whitespace/comments] [5] Total errors found: 14 in 19 files If any of these errors are false positives, please file a bug against check-webkit-style.

Alex Christensen

Comment 3 2016-08-15 13:00:35 PDT

Created attachment 286079 [details] Patch

Alex Christensen

Comment 4 2016-08-15 13:15:08 PDT

Created attachment 286082 [details] Patch

Alex Christensen

Comment 5 2016-08-15 13:27:25 PDT

Created attachment 286085 [details] Patch

Alex Christensen

Comment 6 2016-08-15 13:36:29 PDT

Created attachment 286088 [details] Patch

Brady Eidson

Comment 7 2016-08-15 14:20:06 PDT

Comment on attachment 286088 [details] Patch Rubber-stamp based on it being a pure rename that we discussed in person.

Alex Christensen

Comment 8 2016-08-15 14:25:18 PDT

https://trac.webkit.org/changeset/204483

Alexey Proskuryakov

Comment 9 2016-08-15 22:59:48 PDT

Impl is an abbr :(

Alex Christensen

Comment 10 2016-08-16 10:45:41 PDT

We have BlobRegistry, BlobRegistryProxy, and BlobRegistryImpl. We will soon have SocketStreamHandle, SocketStreamHandleProxy, and SocketStreamHandleImpl. If anyone suggests a better naming scheme, I will use it.

Note You need to log in before you can comment on or make changes to this bug.