Web Inspector: Large class lists are not easily discoverable with "Classes" quick-toggle

• Component: Web Inspector
• Status: RESOLVED FIXED

[Devin Rousso]

Created attachment 286075 [details]
[Image] Screenshot of issue

If an element has a lot of classes, it is hard to see that there are more classes in the "Classes" quick-toggle area

[Devin Rousso]

Created attachment 286083 [details]
Patch

[Radar WebKit Bug Importer]

<rdar://problem/27852460>

[Devin Rousso]

Created attachment 286084 [details]
[Image] After Patch is applied

[Joseph Pecoraro]

Comment on attachment 286083 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=286083&action=review

r=me

> Source/WebInspectorUI/UserInterface/Base/DOMUtilities.js:90
> +WebInspector.linkifyNodeReference = function(node, maxLength = Number.POSITIVE_INFINITY)

We normally just use Infinity instead of Number.POSITIVE_INFINITY.

But how about just keeping it undefined here and doing:

    var displayName = WebInspector.displayNameForNode(node);
    if (maxLength)
        displayName = displayName.truncate(maxLength)
    ...

It reduces the work in the common case (no truncate).

[Devin Rousso]

Created attachment 286149 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 286149 [details]
Patch

Clearing flags on attachment: 286149

Committed r204496: <http://trac.webkit.org/changeset/204496>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.