Bug 16085

Summary: Web Inspector's Network Timeline graph code clean up and misc. fixes
Product: WebKit Reporter: Timothy Hatcher <timothy>
Component: Web Inspector (Deprecated)Assignee: Timothy Hatcher <timothy>
Status: RESOLVED FIXED    
Severity: Minor    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch aroben: review+

Description Timothy Hatcher 2007-11-21 12:12:19 PST 
The Network Timeline graph code has a couple of problems.

- It defines a few global functions that should be nested or hanging off another object/prototype.
- It recomputes the segment percentages twice, once for the main pill and another time for the reflection.
- Sometimes the percentages will round down so the total is below 100%. (We already account for a total greater than 100%.)
- The pill shadow is drawn with a stoke on a pixel boundary, to achieve a blurry line. We should use the canvas shadow drawing properties.
Comment 1 Timothy Hatcher 2007-11-21 12:18:50 PST 
Created attachment 17434 [details]
Patch
Comment 2 Timothy Hatcher 2007-11-21 12:20:02 PST 
This patch also removes un-needed save/restore calls.
Comment 3 Adam Roben (:aroben) 2007-11-21 15:04:55 PST 
Comment on attachment 17434 [details]
Patch

r=me
Comment 4 Timothy Hatcher 2007-11-21 15:40:45 PST 
Landed in r27943. http://trac.webkit.org/projects/webkit/changeset/27943